Comments (3)
WRT your second point, could you not add the validation to the DAO itself, so each DAO can decide whether or not it wants to continue execution or error out if the size is too large?
from broadway-api.
Yes as @nblei mentioned the two possible solutions we are looking at are:
- Adding a new optional field here in the grading stage called
logs
which is true by default. When set to false, the Broadway grader would discard the logs generated. - MongoDB has a limit of 4MB (old versions) and 16MB (newest version) of document size. We could calculate log size on the broadway grader and if it is above 4MB, we save logs as:
{
"stdout": "",
"stderr": "Logs not saved because it was more than 4MB",
}
My concern with the second solution is that it is very Mongo specific while we have made an attempt to create a DAO layer so people could plug in other databases. #29
Thoughts @nmagerko @rod-lin @bhuvy2
from broadway-api.
Truncation and/or validation in the DAO seems like the way to go for extreme cases, but having a logs
option in the grading stage sounds like a very reasonable thing to have as well.
from broadway-api.
Related Issues (20)
- Possible Post Processing Failure HOT 1
- Grader Endpoint include Id
- On Demand Grading? HOT 1
- Documentation HOT 3
- Revert to non blocking poll HOT 1
- Refactor Database Interaction HOT 1
- Environment Variables Structure HOT 3
- We need HTTPS HOT 1
- Refactor Module Src Appropriately
- Add --cap-add to statge config HOT 1
- Do Not Share Roster
- Log API Endpoint HOT 1
- Course Worker Nodes Endpoint HOT 3
- Extend API to allow for Packaged Containers HOT 5
- Worker Node Display erroneous after restart of a worker node HOT 2
- Handle False Failure Detections
- Improve flags and configuration HOT 4
- Should specify bind address in config
- Need timestamp in logging
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broadway-api.