scroll and pageChange events from ScrollContainer about famous-flex

[toostn]

I think this fixes the scroll event, but I haven't had the time to examine it thoroughly enough to make a pull request.

ScrollController.js:1663

// When scroll-offset has changed, emit scroll-start event
if (this._scrollOffsetCache !== scrollOffset) {
    if (!this._scroll.isScrolling) {
        this._scroll.isScrolling = true;
        this._eventOutput.emit('scrollstart', eventData);
    } else {
        this._eventOutput.emit('scroll', eventData);
    }
}

[IjzerenHein]

Hello Torsten, glad to hear you like the component!
Your suggestion sounds like a great idea!
I think the code you suggest would work, but I think it would be better if the scroll event is emitted after the layout has been recalculated (at the same time, scrollend is emitted`. If you can make a pull request out of it, I'll add it to the codebase.
Cheers,
Hein

[toostn]

Sure, I'll give it a try and also move it to the end of the commit method!

[IjzerenHein]

Awesome!

[IjzerenHein]

Awesome Torsten!

I'm just reviewing the code and I'm going to make some changes it. I think it would be useful to always emit the 'pagechange' event, even when the pagination is not enabled. Also, I'm moving the call to getFirstVisibleItem to after the layout function (it may have changed after the layout has been executed.

I noticed that pagechange is only executed when an actual visibleItem exists. In my interpretation of such an event, it should also emit the event when a change from page A to no page is detected. In that case someone can write an event-handler and for instance clear the detail view when no current page exists.

[IjzerenHein]

I've pushed the changes. The pagechange event is now fired whenever the visible content has changed. So also, when you for instance swap the first item. Basically, whenever the renderable has changed, pagechange is emitted. Also, on startup an event is emitted, when transitioning from no page to page A.

Let me know what you're thoughts are on this.

[toostn]

I agree with you regarding triggering the event when page changes from or to undefined. The idea to only check for page changes when the scrollview was paginated was mostly to avoid unnecessary checks, but it makes sense to not limit the event to paging views.

Thanks for implementing these events!