Coder Social home page Coder Social logo

Comments (5)

khaeru avatar khaeru commented on May 20, 2024

I've just run into this. @zikolach does this require anything special to be changed/added in the Java code? If not, I can take a stab at it.

from ixmp.

zikolach avatar zikolach commented on May 20, 2024

@khaeru feel free to contribute. I wouldn't exclude the case that something doesn't work as expected on Java side as well. There are some tests on both sides (java and python) which seem to work. And also latest ixmp.jar might have this indirectly touched (e.g. in commit a782e2edffeaa6fb4bbb7cbe2fbcd0c79d06e0cd in ixmp_source repo)

from ixmp.

zikolach avatar zikolach commented on May 20, 2024

Related fix https://github.com/iiasa/ixmp_source/pull/141/commits/d5229563430b64a16d005dc477a09628f0591a12 was merged as part of PR iiasa/ixmp_source#141

from ixmp.

danielhuppmann avatar danielhuppmann commented on May 20, 2024

Please look at danielhuppmann@15ddb5d which extends the existing (incorrectly passing) integration tests to make them fail - as they should, because the current implementation does not actually clone a Scenario across platforms. Instead it only clones the Scenario within the same platform and just overwrites the Python-internal mp arg.

from ixmp.

zikolach avatar zikolach commented on May 20, 2024

@danielhuppmann @khaeru there was missing first parameter in clone method (which is needed to cross-db cloning)

from ixmp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.