Comments (11)
Oi, good catch. Let me investigate this later. Thanks!
from bandcamp-dl.
Yeah, something is going on. There is a 88mb pack file in the repo. "pack-8441a5ea089a34e33d5edbae8bb0173c2b9a26b3.pack"
Looks like it is full of .mp3 files caused from the initial commit!
from bandcamp-dl.
Initialized a new repository. You can check it out here
https://github.com/kapitanluffy/bandcamp-dl
from bandcamp-dl.
It would be possible to just erase the .mp3 files in this repository commit history instead of making a new repo without the previous commit history.
from bandcamp-dl.
Yeah, I was planning on removing those MP3 files. It makes me angry that
people just re-upload rather than just forking and implementing a pull
request, I'll fix this tomorrow morning.
On Oct 14, 2015 1:17 PM, "Topher Timzen" [email protected] wrote:
It would be possible to just erase the .mp3 files in this repository
commit history instead of making a new repo without the previous commit
history.—
Reply to this email directly or view it on GitHub
#29 (comment).
from bandcamp-dl.
Yeah understandably. Doing that goes against the whole nature of GitHub.
from bandcamp-dl.
Oh, I initially planned forking/removing but I don't know how I can remove the said mp3 files from the repo. I tried downloading forks of the project but it still has more than 80mb
from bandcamp-dl.
Decided to look into this, and I was able to slim down the repo to 43.25kb:
orchid% hub clone https://github.com/ali/bandcamp-dl
Cloning into 'bandcamp-dl'...
remote: Counting objects: 203, done.
remote: Compressing objects: 100% (63/63), done.
remote: Total 203 (delta 1), reused 0 (delta 0), pack-reused 140
Receiving objects: 100% (203/203), 43.26 KiB | 0 bytes/s, done.
Resolving deltas: 100% (96/96), done.
Checking connectivity... done.
I found a "files" directory in the repo history that had a bunch of mp3s in it, so I removed it and force-pushed the "slimmed" master branch to my fork: https://github.com/ali/bandcamp-dl.git
@iheanyi I don't think this is a change I can merge in because your repo still has the mp3s in its history. You can remove the files directory from the repo history yourself and force-push your master branch back upstream, but I'm not sure what implications this has for previously-created forks pushing their changes in.
To remove the "files" dir from every commit: git filter-branch --prune-empty --index-filter 'git rm -rf --cached --ignore-unmatch ./files' --tag-name-filter cat -- --all
from bandcamp-dl.
@iheanyi you should follow what @ali did and clean the repo history for easier usability.
from bandcamp-dl.
Yeah, gonna do that now. Thanks y'all.
from bandcamp-dl.
Okay y'all, I've fixed this. @ali @tophertimzen and everybody, make sure you do a clean clone of the repo that has all of the messy files removed from it. Thanks!
from bandcamp-dl.
Related Issues (20)
- bandcamp-dl cannot be installed with setuptools >= 58.0.2 due to "demjson" dependency HOT 2
- Error running the script HOT 1
- SOCKS proxy support HOT 3
- Can't download album art HOT 5
- Use less verbose output when finish album download HOT 3
- Unable to download track HOT 3
- Arch PyPI installation command not found HOT 1
- Feature to change location of download HOT 3
- bandcamp-dl command doesnt work anymore HOT 1
- Config file support HOT 4
- Download full wishlist
- --assume-yes option HOT 6
- Downloading doesn't work (TypeError: 'NoneType' object is not subscriptable) HOT 1
- ModuleNotFoundError HOT 3
- Consider editing repository setings to remove "Packages" section HOT 1
- unable to get local issuer certificate HOT 4
- Better error message, if download is not available (incorrect link) HOT 1
- Private tracks bypass - ONLY if private tracks are accessible online HOT 2
- Issue with config file options.
- Exception when using --no-slugify HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bandcamp-dl.