Name "exefs_icon" is not defined about 3dsconv

[ihaveamac]

seems I made a mistake and exefs_icon isn't actually defined if the icon is missing.

[ihaveamac]

4f27733 this commit should fix the error. it won't make the rom convert if the icon is missing but it should not crash at least.

[damnsquidpeople]

I know the files I have should definitely have icons though, at least they do in Citra but I don't know if that has anything to do with this or not(?)

[ihaveamac]

this error should only happen if "icon" wasn't found in the exefs. have you tried the latest commit?

[damnsquidpeople]

Latest commit doesn't have the error showing up but it still appears to not convert on my end, which I'm not sure if that's intended or not?

[ihaveamac]

what's the output?

[Crono141]

Hey, I'm running into the same problem as above. When I try and run the new commit with python, I get this error.

[ihaveamac]

@Crono141 make sure you're using Python 3.4 or later. run it like: py -3 3dsconv.py ...

[Crono141]

Thanks, after installing python3 and installing pyaes, I was able to get ONE of my files to convert. The rest gave this error:
[image removed due to rom url]

Which I think brings us back to what @damnsquidpeople was saying last year.

[ihaveamac]

The crypto flag was probably not set correctly when it was decrypted.

[Crono141]

Anything I can do about that?

[ihaveamac]

Consider re-dumping with modern tools, GodMode9 can also create a cia directly from a game cart.

[Crono141]

OK. Thanks.