Comments (13)
Hello. If you're (or someone) still ineresting in, I've created a branch with ActiveRecord 5 fix:
https://github.com/Xanders/em-synchrony/tree/active_record_5
Use it in Gemfile like:
gem 'em-synchrony', github: 'Xanders/em-synchrony', branch: 'active_record_5', require: %w[em-synchrony em-synchrony/mysql2 em-synchrony/activerecord em-synchrony/em-http em-synchrony/fiber_iterator] # just a sample, fill the require list by yourself
Also it looks like tests was fixed two months ago: 1a232d2
So project is not totally dead. Hope to see EM-Synchrony support in ActiveRecord-Import in the future again...
from em-synchrony.
@Xanders Hey, is there a reason you've branched your fix not from master, but from a proposed pull request branch?
from em-synchrony.
@dgutov Yes, it's because my fix is based on changes from that PR, so we should wait for #190 to be merged until it will be possible to merge my fixes.
from em-synchrony.
my fix is based on changes from that PR
Any particular reason for that?
#190 would have to be rebased first.
from em-synchrony.
@dgutov Is there any other way to create PR with code using code from other PR except of copy-paste all of that code? I don't understand what the problem now, sorry.
from em-synchrony.
I'm asking why you've used the approach from that PR and not followed the approach that we currently have in master.
from em-synchrony.
@dgutov I've tried current master code (both active_record.rb and active_record_4.rb) with AR5 and had a lot of strange errors, didn't know how to fix them. But when i tried fork from #190 it was almost worked except of some moments, that i fixed. I assumed fork is more recent version of synchrony/ar then current master, so I'm forked it, not master.
Was it wrong?
from em-synchrony.
It's not more recent, no. But it's possible that it uses a better approach, considering you've had to fix fewer places.
from em-synchrony.
@dgutov So I was wrong, sorry. But I think code from that fork is much simpler and more stable, so I still prefer it.
But note, I didn't write any heavy/complex tests yet, so some bugs may be there.
from em-synchrony.
Do the existing tests pass?
from em-synchrony.
@dgutov Only my app's tests. I didn't run synchrony's tests, I don't have much time. It was just a quick fix to force my app working.
from em-synchrony.
Please let us know the result when you get around to it.
from em-synchrony.
Hey folks, could you please try the current em-synchrony master?
See if it works okay with your AR5 based applications.
from em-synchrony.
Related Issues (20)
- Example redis call inside receive_data HOT 1
- Can't require 'em-synchrony/amqp' HOT 11
- Goliath is not async by default HOT 3
- Assistance with mysql2 issue #489 HOT 3
- Mongoid patch is out of date HOT 1
- Issue when using Pipelining using Synchrony Driver with Redis - Connections not released? HOT 2
- Make a new release HOT 2
- uninitialized constant ActiveRecord::ConnectionAdapters::ClosedTransaction HOT 19
- em_mysql2 should turn on strict mode HOT 4
- em-synchrony/activerecord not work on ActiveRecord 4.2.1 HOT 1
- How to early return using FiberIterator HOT 3
- Support Rethinkdb? HOT 3
- FiberIterator breaks normal exception handling HOT 3
- Does this support PostgreSQL? HOT 2
- How to perform an imap call in a fiber iterator? HOT 1
- FiberError: can't yield from root fiber
- Fail with gem listen HOT 2
- Use of deprecated ::Fixnum in AR connection adapter HOT 2
- Synchronization timing is broken in nested-callback situation. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from em-synchrony.