remove MO test mo-basic-240 about epub-testsuite

[OriIdan]

If it does not test anything in the spec. I would opt to remove it.

[danielweck]

"mo-basic-040 Volume Control

Tests whether the volume of the Media Overlay playback can be independently
adjusted.

If you can independently adjust the MO volume, then the Reading System
supports volume control."

spec. is explicit only for embedded media:
"
Reading Systems should expose User controls for the volume levels of each
independent audio track (i.e. from the audio element of the Media Overlay,
and from the embedded audio or video media within the EPUB Content
Document), ... ... Reading Systems are not required to handle simultaneous
volume levels in any particular way.
"

otherwise, just this implicit reference:
"
User-controllable audio playback options should include timescale
modification, in which the playback rate is altered without distorting the
pitch.
"

i am not against removing basic-240
daniel

On Monday, March 17, 2014, Marisa DeMeglio [email protected] wrote:

It doesn't test anything in the spec; it's just a reading system behavior
test.

Reply to this email directly or view it on GitHubhttps://github.com//issues/53
.

[mattgarrish]

Is the question 040 or 240?

I’d keep 040 as there should be a test for independent volume control, but 240 doesn’t make a lot of sense to me.

Was it meant to test whether the user can change the highlighting colour? That would be a helpful thing, and would be more in line with “custom” styles, but the current wording about reading system default styles isn’t useful. We already test if RS highlighting is possible in 220.

Matt

[danielweck]

Damn...040 vs. 240
Apologies for my brain fart. We are indeed talking about this:

https://github.com/mgylling/epub-testsuite/blob/master/content/30/epub30-test-0220/EPUB/xhtml/basic_tests.xhtml#L34

Well, Readium implements default "media overlays active" styling (when the CSS class is not specified in the source material), but the specification doesn't say that we "should":

http://www.idpf.org/epub/30/spec/epub30-mediaoverlays.html#sec-docs-assoc-style

Test #240 is in fact nonsensical, because the CSS class is declared in the OPF:

https://github.com/mgylling/epub-testsuite/blob/master/content/30/epub30-test-0220/EPUB/package.opf#L15

Note that Readium also implements style overrides, but that's a different story.

[mattgarrish]

This also has me questioning 230. Should we use yellow as the test for author control over the highlighting? It seems like a common enough RS-default colour that you might get false positives, or not be able to say for sure if you're paying attention. Hot pink is always nice.

[marisademeglio]

I think test 240 was looking more towards testing user agent overrides but really I think things like this will be covered by the upcoming accessibility testsuite.

Hot pink would look nice on 230!