Comments (7)
See #397
from identitymodel.oidcclient.
Hi,
thanks! What's the benefit of that?
from identitymodel.oidcclient.
Well..
In that case IdentityModel.OidcClient package will not add dependencies which it doesn't use or doesn't need: i.e. referrences package A which referrences package B and only code from B is really required.
JFI:
Microsoft.Extensions.Logging in case of netstandard 2.0 has next dependencies:
[Microsoft.Bcl.AsyncInterfaces](https://www.nuget.org/packages/Microsoft.Bcl.AsyncInterfaces/) (>= 7.0.0)
[Microsoft.Extensions.DependencyInjection](https://www.nuget.org/packages/Microsoft.Extensions.DependencyInjection/) (>= 7.0.0)
[Microsoft.Extensions.DependencyInjection.Abstractions](https://www.nuget.org/packages/Microsoft.Extensions.DependencyInjection.Abstractions/) (>= 7.0.0)
[Microsoft.Extensions.Logging.Abstractions](https://www.nuget.org/packages/Microsoft.Extensions.Logging.Abstractions/) (>= 7.0.0)
[Microsoft.Extensions.Options](https://www.nuget.org/packages/Microsoft.Extensions.Options/) (>= 7.0.0)
[System.Diagnostics.DiagnosticSource](https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/) (>= 7.0.0)
And Microsoft.Extensions.Logging.Abstractions
has only next dependencies for netstandard2.0:
[System.Buffers](https://www.nuget.org/packages/System.Buffers/) (>= 4.5.1)
[System.Memory](https://www.nuget.org/packages/System.Memory/) (>= 4.5.5)
PS: on my project due to such depencies from IdentityModel.OidcClient and another package got a runtime issue that one of dependencies wasn't found (yeah, compiler lost
it during build) so I had to explicitly reference Microsoft.Extensions.Logging project to make it working again.
from identitymodel.oidcclient.
OK.
What will happen to existing clients when they call e.g.
options.LoggerFactory.AddSerilog(serilog);
Will it throw - or just do no logging?
from identitymodel.oidcclient.
yeah, thats a good spot..
it will do no logging as NullLoggerFactory is being used
So from that point of view that change is breaking and probably its better to keep it as it is
from identitymodel.oidcclient.
But it will not break (e.g. throw an exception) ?
I personally agree with reducing dependencies. We will do a major release anyway soon....
from identitymodel.oidcclient.
Will not break link
AddSerilog
callsAddProvider
which do nothingCreateLogger
returnsNullLogger.Instance
from identitymodel.oidcclient.
Related Issues (20)
- Is there a way to have OIDC Client not persist the login on the Duende Oauth server? HOT 4
- Load ProviderInformation from .well-known/openid-configuration HOT 4
- Fix client builds HOT 1
- Getting StackOverflowException at JsonDocument.Parse(content!).RootElement HOT 4
- Discovery Document Request does not use Discovery Policy Authority for Request Address
- PAR support
- Make Client Assertions more extensible
- Investigate private network access spec
- StepUp Auth, Claim and FrontChannelExtraParameters
- Has the default grant type changed? HOT 8
- Blazor Assembly supports?
- Is the accesstoken in the JWT format
- Problem with redirection on WinUI
- Not passing StartUrl to Browser in .net-ios HOT 3
- OidcClient.LoginAsync fails with 'Failed to push authorization parameters' after upgrade to 6.0.0 HOT 3
- Only first login works, when launching app again, it doesnt
- Optimize Token Refresh Synchronization in RefreshTokenDelegatingHandler to Reduce Unnecessary Lock Contention HOT 3
- Cannot separate user cancel from Logout done in oidcclient logout async
- Confusing "state" query parameter causes bad request on Keycloak
- CreateEndSessionUrl extra parameters? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from identitymodel.oidcclient.