Errors in prepare_geoclim function about cdms.products

[dannyparsons]

month_abb_english is defined in constants.R. Surprised if it doesn't find it in functions?

1. Yes, good idea.
2. The GeoCLIM documentation mentions "ID" #17 (comment) so I think keep it as ID.
3. character. It is for a set of additional station columns that you might want to include in the output, but not mandatory e.g. station elevation or country.

I can look into the error later if you still can't find the cause.

[lilyclements]

@dannyparsons thanks! I've sorted 1-3 now.

To the error - we currently run in the function:

  geoclim_data <- 
    tidyr::pivot_wider(data_with_meta,
                       id_cols = tidyselect::all_of(id_cols),
                       names_from = tidyselect::all_of(month),
                       values_from = tidyselect::all_of(elements), 
                       values_fill = -999)

I was initially not running this with summary data, just the daily data. The output was then giving a vector of values when running pivot_wider.
Having values_fill = -999 then caused the error.

So this is fixed now that I am using it correctly!