Coder Social home page Coder Social logo

Comments (13)

iddan avatar iddan commented on July 17, 2024

This has to do with the DPI of the device. What is the Android device you're testing on?

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

I am using Samsung Galaxy S7 and iPhone 7+

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

But most of the android users use devices like this and as I know, Samsung has high DPI than iPhones.

from react-native-canvas.

iddan avatar iddan commented on July 17, 2024

Are you running on an emulator or an actual device?

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

I am running on actual devices, not simulators.
Those screenshots are what I have taken from my phones.
If you want to test that on your side, I can upload the whole component code.
Please let me know if you need it.

from react-native-canvas.

iddan avatar iddan commented on July 17, 2024

Why are you running this code only for iOS?

if (Platform.OS === 'ios') {
        this.canvas.width = width
        this.canvas.height = height
}

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

I often had issues when the width & height gets bigger than 150 on iOS, it worked weird so I implemented scaling for iOS components.

from react-native-canvas.

iddan avatar iddan commented on July 17, 2024

If you are changing the canvas size you should set it through canvas.width and canvas.height for Android as well.

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

So you mean, I set canvas.width & canvas.height for Android as well and implement the scaling again for android?
Intersting....
Let me try...

from react-native-canvas.

iddan avatar iddan commented on July 17, 2024

You should not do scaling yourself. React Native Canvas auto-scales your canvas dimensions according to the device dimensions. You should set the sizes to your desired values and let the component do the heavy lifting.

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

@iddan , I am a little confused how to deal with it. Can you fix some code snippet?

https://gist.github.com/cooleagle8837/bfc16b4fb061e4fe4af48b521ca3b070

from react-native-canvas.

iddan avatar iddan commented on July 17, 2024

Unfortunatley I don't have the time to debug in the moment. Will try to get it later

from react-native-canvas.

batmanhit avatar batmanhit commented on July 17, 2024

If you have no time, I will try to debug but actually, I cannot understand what you mean and how I can fix that. I will try various methods you have in mind.

from react-native-canvas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.