propertycollector got no return value if esxi host doesn't have any virtual machines about icingaweb2-module-vspheredb

[Thomas-Gelf]

Good catch, I never tested it with an empty host. Thanks for reporting this! I'm wondering why there is no "returnval" in the response, if that's "normal" I shouldn't throw an error. It would be great if you could turn on SOAP "debugging" like we did last time and let me have the whole related response.

[Thomas-Gelf]

@vita2: thanks for all the details. In case anyone is facing the same issue, this is what helped to fix it in PropertyCollector.php:

     protected function makeNiceResult($result)
     {
         if (! property_exists($result, 'returnval')) {
-            throw new IcingaException('Got no returnval');
+            return [];
         }

Right now I'll not push this to master, as the Exception originally helped to work around an issue with the SOAP API failing to tell about an expired session. Will fix this once I tracked down that other problem. Systems with no VMs are the lesser evil, so for now they have to wait 😆.

[Thomas-Gelf]

@vita2: does this still happen with v1.0.2?

[Thomas-Gelf]

No feedback, is probably fixed