Coder Social home page Coder Social logo

Comments (4)

ReeceHumphreys avatar ReeceHumphreys commented on June 2, 2024

It is primarily a rendering issue since we put all backquoted text inside these mini-code rectangles. This doesn't leave much space when you have multiple lines with backquotes on top of each other. We could get rid of the rectangles or increase the line height. Either of those would help with readability.

I'll take a look into what other people do for their docs.

from icerpc-docs.

bentoi avatar bentoi commented on June 2, 2024

I added back quotes for port numbers to be consistent with the use of <c> in our C# API documentation. I agree it's not a good idea as it's less readable.

I also added back quotes for few C# type names. I would always use back quotes for API type names or language keywords.

In #33, for text such as "on the Compress interceptor, and then finally the Compress interceptor", instead of adding backquotes to Compress (a type that doesn't exist in our C# API), I've changed Compress to compress. I would not use the PascalCase naming convention here since we aren't referring to a C# API.

One remaining debatable use of back quote is in this text: "An invoker implementation can call invoke on another invoker, which itself calls invoke on another invoker, etc.;". We use back quotes for "invoke" which isn't really a method name that exists. And we don't use InvokeAsync for a good reason, our documentation shouldn't be tied to a specific language mapping. Should we keep the back quote for "invoke"? I think I would drop them or rephrase the sentence to not refer to a method.

from icerpc-docs.

externl avatar externl commented on June 2, 2024

"An invoker implementation can call invoke on another invoker, which itself calls invoke on another invoker, etc.;"

I think "calls invoke on another invoker" sounds odd. I would say that it just "calls on another invoker"

We could write:

"An invoker implementation can call on another invoker, which itself can call on another invoker, etc.;

from icerpc-docs.

ReeceHumphreys avatar ReeceHumphreys commented on June 2, 2024

Just for note, I committed a minor tweak to the css that should make backquoted text more readable: 4c14206

from icerpc-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.