Coder Social home page Coder Social logo

Comments (5)

moovida avatar moovida commented on August 16, 2024

I confirm that it is that value, but am not sure how to handle this, since there is no simple way to make it size-aware in that position.

from flutter_map_line_editor.

moovida avatar moovida commented on August 16, 2024

@ibrierley , would it be too ugly for you to add optional size values as:

  PolyEditor({
    this.points,
    this.pointIcon,
    this.intermediateIcon,
    this.callbackRefresh,
    this.addClosePathMarker,
    this.pointIconSize = 30,
    this.intermediateIconSize = 30,
  });

so that it would result in:

      dragMarkers.add(DragMarker(
          point: this.points[indexClosure],
          width: pointIconSize,
          height: pointIconSize,

This seems to be working nicely.

from flutter_map_line_editor.

ibrierley avatar ibrierley commented on August 16, 2024

I was going to write this:

Yes, that was an oversight I think, I didn't originally spend a lot of time on this one, and was just trying to get a minimal case up. You could try adding width/height parameters for the PoltEditor class (I guess separate ones for both the point/cornerIcon and the intermediateIcon), and then use them lower down and see how that goes, and naturally feed back if it works ok. I think that would be a sensible addition to the lib, otherwise I'll have a bash when I get chance.

So I think that matches up with your post just now. I don't see anything ugly with that at all. Whether we'd want height always be the same as width, I suspect we probably do, but I wouldn't have any complaints if that was passed in as a Size object or separate width/height params

from flutter_map_line_editor.

moovida avatar moovida commented on August 16, 2024

Thanks a lot @ibrierley . I have a meeting now, but later I will try the size object option and in case propose you a pull request.

from flutter_map_line_editor.

moovida avatar moovida commented on August 16, 2024

This changed has been addressed in PR #12

from flutter_map_line_editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.