Coder Social home page Coder Social logo

Comments (3)

gyliu513 avatar gyliu513 commented on June 10, 2024

@morningspace does the custom sizing depend on resource locker? We may not able to GA this feature if it depends on resource locker as it is another open source component.

from cp4waiops-gitops.

morningspace avatar morningspace commented on June 10, 2024

@gyliu513 The reason it still has resource locker after switch to configmap is that the current configmap does not cover all cases which are originally covered by the resource locker, i.e.: configmap only addressed a subset of the custom sizing needs addressed by resource locker.

While I believe the configmap approach should be improved to cove all cases in the coming releases, for now in this release, I think we have a couple of options:

  • To indicate in docs (previously I put it in tech-preview folder before the final version of the repo layout) that the custom sizing gitops configuration is just a sample configuration which will not be officially supported and subject to change comparing w/ other gitops configuration in this repo. So, we split it out and let customer know that's not part of GA feature.

  • To remove resource locker from the current x-small gitops configuration and make this as part of GA feature as well. This will loose some custom-sizing capabilities which are originally supported when using resource locker.

  • To keep the resource locker configuration along w/ the custom sizing configmap but provide a switch (turned off by default) in values.yaml w/ clear note that only the configmap is officially supported, while the resource locker configuration is just a sample to extend the custom sizing capability to cover more cases which will not be officially supported and subject to change. Customers should be aware of this before they turn it on.

from cp4waiops-gitops.

morningspace avatar morningspace commented on June 10, 2024

@lihongbj

from cp4waiops-gitops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.