Comments (2)
Rather than a sink connector configuration option I think providing (and documenting) a SMT that is able to insert the message key into the message value as an _id
field is the way to go.
from cloudant-kafka-connector.
Looking at the complexity that is coming out in #82 from trying to handle all the variations of inserting an _id
into different types of messages and associated schema updates I think we need to re-think how we handle this.
One option would be to:
- Modify the
ConnectRecordMapper
to check for the presence of a custom header on the record and use the value of that header as the ID. - Use the
org.apache.kafka.connect.transforms.HeaderFrom
to convert a key to the header, avoiding the need for us to have any custom SMT.
For the header, we would ensure the StringConverter was used as we only want strings for IDs. We would need to document the name of the header and the expectation that the value is a string. (this would cause errors for things that cannot convert cleanly to strings, inline with general Kafka behaviour on converters).
We would overwrite existing _id
in the JSON blob before writing to Cloudant (with a warning).
from cloudant-kafka-connector.
Related Issues (20)
- remove org.json
- Tidy up docs HOT 2
- Cap on batch size
- Split topics and partitions across multiple sink tasks
- Revisit source connector topic partition assignment HOT 2
- Refactor source partition offset map
- Configuration table of README should be generated from `ConfigDef`
- Source connector can't serialise numbers correctly
- ConnectRecordMapper#apply doesn't support nested lists HOT 1
- Include signature with published jar
- `cloudant.since` defaults to 0 which means the connector always starts from the beginning on restarts
- SourceChangesTask should use `longpoll`
- Docs updates
- Use parameterized logging where possible
- DocumentToSourceRecord: write key as a `Struct` to kafka
- Revisit build.gradle dependency declarations
- Upgrade tests to junit 5 (junit jupiter)
- Move to mockito
- Update kafka deps to 3.4.0
- Update cloudant-java-sdk to 0.4.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudant-kafka-connector.