Ignore/disable prettier didn't works about prettier-loader

[iamolegga]

strange, what versions of prettier and prettier-loader do you use?

[iamolegga]

and could you provide examples of code with comments?

[DrBoria]

"prettier": "^1.10.2",
"prettier-loader": "^2.0.1",
"webpack": "^3.10.0",

Well. I user prettier loader with webpack-dev-server. And I'v got file with react routes. Each route is longer, than 120 symbols (that I set in prettier-loader config), but event after adding 'ignore', 'disable' etc. comments it changes file with routes.

Config for prettier loader in webpack
{ test: /\.jsx?$/, use: { loader: 'prettier-loader', options: { useTabs: false, tabWidth: 2, singleQuote: true, printWidth: 120, trailingComma: 'all', bracketSpacing: true, arrowParens: 'always' }, } }

[iamolegga]

Could you please provide example of jsx code where you write comments

[iamolegga]

I mean how you write comments inside jsx?

[DrBoria]

Like this
http://take.ms/JbJ8w
Just at the top of the file.

[iamolegga]

Thanks, I think I'll add test for this case today, and take a look what's going on

[iamolegga]

Sorry for so long waiting, as @rchaser53 just wrote in another issue, his own version of prettier-loader does support of .prettierignore files, so you can try it:
https://github.com/rchaser53/prettier-loader, or wait for a week (I hope so) until I’ll fix it in this package

[iamolegga]

So, I just added test for ignoring prettier using comments, and it works, see this commit, because it's the same as if you just tried to run prettier-cli on your code.
The next thing is to check/fix work with .prettierignore file, working on it

[iamolegga]

What about trying to prevent formatting with comment, I think the problem that

A JavaScript comment of // prettier-ignore will exclude the next node in the abstract syntax tree from formatting.

And the next node in the abstract syntax tree in your example is // prettier-disable and all next code will be formatted.

So yes, if you want to ignore the whole file it's better to keep it in .prettierignore

[iamolegga]

fixed in #12

npm version 2.1.0