Coder Social home page Coder Social logo

Remove .polyfill() api. about smoothscroll HOT 3 CLOSED

iamdustan avatar iamdustan commented on July 24, 2024
Remove .polyfill() api.

from smoothscroll.

Comments (3)

DanielHeath avatar DanielHeath commented on July 24, 2024 1

It provides a hook for things like rewire and makes it easier to manage when doing e.g. universal server rendering.

from smoothscroll.

jeremenichelli avatar jeremenichelli commented on July 24, 2024

@DylanPiercey this not an issue indeed but more of a decision to follow the pattern used in other polyfills. in this case, the best way is to provide to developer to implicitly apply the polyfill, as @DanielHeath mentioned, to avoid errors in certain cases.

from smoothscroll.

coladict avatar coladict commented on July 24, 2024

I think this explanation should be added to the Readme.md

import smoothscroll from 'smoothscroll-polyfill';
smoothscroll.polyfill(); // call when initializing web-page or it won't work

Because as someone not familiar to the disaster that is the JS eco-system, I would never know that the given example require('smoothscroll-polyfill').polyfill(); translates to that.

from smoothscroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.