el.scrollIntroView() doesn't work about smoothscroll

[jeremenichelli]

Fixing this soon. Mayor refactor on the way 😃

[jeremenichelli]

Just merged a new version addressing some issues around scrollIntoView among other improvements so this polyfill is kinda useful to you now @stevenvachon, check it out and let us know if you find a specific bug.

[stevenvachon]

Thanks!

[iamdustan]

Oh man! I knew I was neglecting something when I did that so quick; totally didn’t think of that being the use case.

I’ll look into this. Thanks for the report.

[iamdustan]

@ebidel I just added some initial support for el.scrollIntoView(). I haven’t tested it too heavily yet; but feel free to try it out on https://github.com/GoogleChrome/chromium-dashboard and let me known how it goes. I tried to get a head start on it for you but it has definitely been way too long since I’ve even looked at python to even try to run the project locally.

[ebidel]

Haven't done any debugging yet, but can't get things working out of the box. I think it's the call to findScrollableParent() which finds recursively finds the parent. I think the world of Shadow DOM is giving that issues.

https://github.com/iamdustan/smoothscroll/blob/master/smoothscroll.js#L130

[iamdustan]

Ah. Good point. I’m down for digging through this a bit more if you can point me in the right direction for working with the Shadow DOM. I have a decent amount of theoretical knowledge from following Polymer and the few standards from a distance, but haven’t dug into it too deep. Is there an easy way to get chromestatus.com running locally or another place you’d recommend starting so I spend more time fixing this and less time learning Polymer off the bat?

[jeremenichelli]

@ebidel I know this issue is old, but in case you have time and since I don't know a lot about SHADOW DOM can you provide a simple fiddle to show when this doesn't work? I would like to solve this bug.

[ffuubarbuzz]

I'm not sure if I fixed exact this bug in #18, but at least the same symptom.

[callumlocke]

Where it says "incomplete" in the readme, is that referring to this issue?

[stevenvachon]

This function only works correctly in Firefox -- meaning that it's probably using the native function. This polyfill is kinda useless.

[jeremenichelli]

All good people in this thread, if you see scrollIntoView not working correctly, rise your hand or open an issue better with an example and browser where it fails so I can help you. Happy smooth scrolling!