Comments (5)
Thank you for suggesting this, and providing those very useful links.
I've done initial setup on travis branch.
There also is testing release that will be deleted after I merge travis branch into master.
Can you review it? There are some points I doubt:
- Enabling i686 support
- Disabling freebsd support
- Is that optimal way to build multiple binaries?
- Is travis.yml optimal (that's my first CI setup)?
from page.
It all seems reasonable. I know the recent versions of trust use cross which adds a lot of extra complexity, so I might have missed some things when digging into your setup.
btw is there anything about this project that doesn't work on Windows? Should support for that be added?
Enabling i686 support
What is the concern? Whether to enable it or not? I'd probably say its fine to skip in this era
Disabling freebsd support
What is the concern?
Is that optimal way to build multiple binaries?
Looks like what I'd do. Again, I plan to make this part trivial in the future
Is travis.yml optimal (that's my first CI setup)?
For the bare bones of creating pre-built binaries, it seems fine. See my crate-ci documentation for how you can offload various parts of reviewing PRs onto your CI. If nothing else, it sets a clear bar for contributors that they are less likely to take personally when told to go fix it.
from page.
On an unrelated note, thought I'd pass along human-panic which is a recent creation of some CLI-WG members
https://github.com/yoshuawuyts/human-panic
from page.
is there anything about this project that doesn't work on Windows? Should support for that be added?
Yes. I use named pipe for communication between page
and pty-agent
. That requires libc
and some std::os::unix
stuff, which fails to build on Windows.
Replacing that pipe with something more portable and drop libc
dependency seems to be reasonable.
Edit: Windows also don't have /dev/stdin
and /dev/stdout
equivalents, which is critical.
So it's very unlikely that it will be supported
Disabling freebsd support
What is the concern?
It seems to be quite unpopular nowadays and there is very little chance that someone will find binaries for it useful
See my crate-ci documentation for how you can offload various parts of reviewing PRs onto your CI. If nothing else, it sets a clear bar for contributors that they are less likely to take personally when told to go fix it.
Okay, it does make sense, but before I need to decide about my own code style and probably fix some inconsistencies in code
Thank you, I will check it out
from page.
I've issued 1.0.0 version, binaries for it might be found on releases page
from page.
Related Issues (20)
- Error when opened without existing nvim instance HOT 4
- Add quit-if-one-screen option HOT 2
- NVIM_LISTEN_ADDRESS= page FILE not revokes -o option HOT 1
- Search for pattern and move cursor HOT 4
- How to make gg - (go to first line) work by default HOT 2
- Broken pipe on next_release HOT 24
- First run mess HOT 2
- Allow negative values for `-O open_lines` HOT 6
- Remapping <C-\> cause problem in page HOT 2
- Paging output of running commands; I/O Error HOT 2
- next_release: stream did not contain valid UTF-8 HOT 2
- Color for manpages? HOT 1
- `-O` flag doesn't consider terminal width
- panic after configuring MANPAGER on macOS HOT 3
- AUR - error: failed to build 'page-git-v3.1.2-1' HOT 5
- Feature Request: cat mode HOT 6
- Cannot parse $RUST_LOG value: ParseLevelError(()) HOT 3
- MANPAGER doesn't completely quit HOT 3
- Any Possible Way to have Page ignore/bypass greeter plugins like alpha HOT 1
- bat syntax support does not match vim HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from page.