Coder Social home page Coder Social logo

Pre-built binaries about page HOT 5 CLOSED

i60r avatar i60r commented on August 24, 2024
Pre-built binaries

from page.

Comments (5)

I60R avatar I60R commented on August 24, 2024

Thank you for suggesting this, and providing those very useful links.

I've done initial setup on travis branch.
There also is testing release that will be deleted after I merge travis branch into master.

Can you review it? There are some points I doubt:

  1. Enabling i686 support
  2. Disabling freebsd support
  3. Is that optimal way to build multiple binaries?
  4. Is travis.yml optimal (that's my first CI setup)?

from page.

epage avatar epage commented on August 24, 2024

It all seems reasonable. I know the recent versions of trust use cross which adds a lot of extra complexity, so I might have missed some things when digging into your setup.

btw is there anything about this project that doesn't work on Windows? Should support for that be added?

Enabling i686 support

What is the concern? Whether to enable it or not? I'd probably say its fine to skip in this era

Disabling freebsd support

What is the concern?

Is that optimal way to build multiple binaries?

Looks like what I'd do. Again, I plan to make this part trivial in the future

Is travis.yml optimal (that's my first CI setup)?

For the bare bones of creating pre-built binaries, it seems fine. See my crate-ci documentation for how you can offload various parts of reviewing PRs onto your CI. If nothing else, it sets a clear bar for contributors that they are less likely to take personally when told to go fix it.

from page.

epage avatar epage commented on August 24, 2024

On an unrelated note, thought I'd pass along human-panic which is a recent creation of some CLI-WG members

https://github.com/yoshuawuyts/human-panic

from page.

I60R avatar I60R commented on August 24, 2024

is there anything about this project that doesn't work on Windows? Should support for that be added?

Yes. I use named pipe for communication between page and pty-agent. That requires libc and some std::os::unix stuff, which fails to build on Windows.
Replacing that pipe with something more portable and drop libc dependency seems to be reasonable.
Edit: Windows also don't have /dev/stdin and /dev/stdout equivalents, which is critical.
So it's very unlikely that it will be supported

Disabling freebsd support

What is the concern?

It seems to be quite unpopular nowadays and there is very little chance that someone will find binaries for it useful

See my crate-ci documentation for how you can offload various parts of reviewing PRs onto your CI. If nothing else, it sets a clear bar for contributors that they are less likely to take personally when told to go fix it.

Okay, it does make sense, but before I need to decide about my own code style and probably fix some inconsistencies in code

https://github.com/yoshuawuyts/human-panic

Thank you, I will check it out

from page.

I60R avatar I60R commented on August 24, 2024

I've issued 1.0.0 version, binaries for it might be found on releases page

from page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.