Comments (5)
Hmm, well xtend
is a dependency, while both react
and react-loadermixin
are peer dependencies. What specific problem have you run in to? I don't think we can make react a hard dependency, since multiple versions of react cannot co-exist (see this also) in the same app.
from react-imageloader.
For react
, that's true, good point. But, for react-loadermixin
, I don't think it is. By its very nature people are already going to have react installed, but loadermixin
is super specific and none of the React projects I'm working on/with at the moment make use of it, only your mixin, so "npm install react-imageloader" yields a "broken" mixin without manually installing a mixin that serves no purpose other than to make yours work. I'd still recommend moving the loadermixin to the regular dependency list, instead.
from react-imageloader.
Interesting. AFAIK npm should auto-install peer dependencies if they are missing (at least, until 3.x is released). Is it possible you're running an edge version of npm?
from react-imageloader.
hm, deleted node_modules, pruned package.json, reran it, and you're right: it installed just fine. I guess that means this can be closed, sorry to bother and thanks for the reponse!
from react-imageloader.
π thanks for providing the sanity check! We may still have to do something when the next version of npm is released, since peer dependencies will stop auto-installing thenβ¦
from react-imageloader.
Related Issues (20)
- Preloader vs Children HOT 1
- Image onLoad callbacks never fire HOT 16
- Set className of <img>? HOT 8
- behavior when src is null HOT 2
- Idea: timeout
- Proposal: Add an option to change the default img tag HOT 6
- A question: how to use to wait until image is available HOT 1
- Support picture elements or let user provide a component
- Not support any events HOT 2
- Opening a link when click on image.
- will u support Android? HOT 1
- Resize image
- `alt` for image HOT 1
- Question: support for `background-image`?
- How do we use the standalone version ?
- Empty string as src will being pending indefinitely HOT 1
- plugin appears to disable browser caching HOT 1
- [feature request] render <noscript> wrapped <img> tag HOT 1
- Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead. HOT 1
- Will this project be updated? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-imageloader.