Coder Social home page Coder Social logo

Comments (6)

jacobc-eth avatar jacobc-eth commented on May 24, 2024

Discussion from Discord:

I think we should just check all known browser routes, and let the user know we detected a browser extension installation we can import on the current Connection modal.

For example, under the MetaMask extension button, we could show text like:

"Import available from Chrome"

or

"Import available from Chromium and Brave"

The next screen would show the list of import options, and include text expaining whats happening.

"By continuing, your MetaMask installation and settings will be synced to HyperPlay."

The user could select from a list of browsers on this screen.

On the next screen, you user will enter their MetaMask password (the unlock password, not the secret recovery phrase.

Then theyre done. Once this is configured, we dont need to display the connect modal on launch anymore simce the connection will persist.

If the user clicks on the wallet connection in the bottom left corner, we will display the connection modal to allow the user to switch to a different connection method (we have a different story for this).

from hyperplay-desktop-client.

pimentel08 avatar pimentel08 commented on May 24, 2024

Screenshot 2022-12-21 at 2.38.51 PM.png

Figma link

from hyperplay-desktop-client.

pimentel08 avatar pimentel08 commented on May 24, 2024

@jacobc-eth If we don't detect a browser extension, we should remove that option from the first modal screen? Or do we keep the option and have it link to their default browser plugin page? (don't know how difficult the second option is)

from hyperplay-desktop-client.

jacobc-eth avatar jacobc-eth commented on May 24, 2024

I think it should be there if we don't detect a browser extension install, and the user can setup up MetaMask using their secret recovery phrase in the typical MetaMask onboarding flow. This should be very easy to implement.

@pimentel08

from hyperplay-desktop-client.

hellowodl avatar hellowodl commented on May 24, 2024

Currently the onboarding screen gets shown at every hyperplay bootup.

Though how would we prevent the user from overwriting their existing wallet?

Should there be another dialog that informa ghe user that this is happening?

@jacobc-eth

from hyperplay-desktop-client.

jacobc-eth avatar jacobc-eth commented on May 24, 2024

The modal should not be re-shown if the user has an active wallet connection method. The only reason we have it poping up on launch each time like that currently is because the current release of the MetaMask SDK we use on mobile lacks session persistence. In Q1, the session persistance issue with the SDK is supposed to be resolved and we can totally do away with that behavior (unless WalletConnect also has a session persistence issue?). Either way, the modal should not be spammed if the user has an active wallet connection method. @hellowodl

from hyperplay-desktop-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.