Invalid type value results in an undefined error about json-schema-core

[jdesrosiers]

I'm not able to reproduce this one. The expected result is for it to throw the result of meta-validation. When I attempt to validate that schema I get the following error.

{
  keyword: 'http://json-schema.org/draft-06/schema#validate',
  absoluteKeywordLocation: 'http://json-schema.org/draft-06/schema#',
  instanceLocation: 'http://example.com/test#',
  valid: false,
  errors: [
    {
      keyword: 'http://json-schema.org/draft-06/schema#additionalProperties',
      absoluteKeywordLocation: 'http://json-schema.org/draft-06/schema#',
      instanceLocation: 'http://example.com/test#/properties',
      valid: false,
      errors: [Array]
    },
    {
      keyword: 'http://json-schema.org/draft-06/schema#properties',
      absoluteKeywordLocation: 'http://json-schema.org/draft-06/schema#/properties',
      instanceLocation: 'http://example.com/test#',
      valid: false,
      errors: [Array]
    }
  ]
}

[ogoldman]

OK--thanks for investigating. I'll take another look at my code, and then provide an update here.

[ogoldman]

Alright, here's what I got tripped up on. When I call validate:

const output = await JsonSchema.validate(schema, instanceJSON, JsonSchema.VERBOSE);

If the schema fails to validate, then this throws--but it doesn't throw an Error. Instead, it throws an output object for the schema. Is this the intended behavior?

[jdesrosiers]

Yes, that's the expected behavior. I've never been happy with the way meta-validation errors are handled. Throwing the output was intended to be temporary until I came up with something I liked better, but I haven't come up with anything yet, so it's still there. I wanted to avoid having to make a custom error implementation, but at this point I should probably do that or prioritize coming up with an approach I like better.

[ogoldman]

Got it. As a client, I think the throw seems reasonable, but not extending Error definitely tripped me up. I would have expected a custom error from which I could retrieve the output object.

Do you want me to close this? Or leave it open as a reminder to revisit this? :)

[jdesrosiers]

Thanks for the feedback. You can leave it open. I'm not sure what I'm going to do yet, but I'll figure something out and take care of it soon.

[jdesrosiers]

I added the custom Error class. I'm still not super happy with it. The part I don't like is that you have to know to look for the validation results in custom property output. I'm concerned that people won't know to look for this field. But, it's not good enough the way it is and I didn't come up with a better option, so this will have to do.