Comments (4)
Prettier's default is 80 chars but it can be changed, see https://github.com/prettier/prettier#print-width. Is that the only issue you have with it? If not, what else bothers you? Some examples of formatting before and after might be useful.
from heracles.ts.
Well, there are a few issues:
https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L147
All arguments are neither in separate lines nor in a single one. I'd expected some consistency, either all arguments should span a separate line, or all should be side by side in single one (if still within the line length limit)
https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L155
Why simple arrow functions should have braces around argument? The less non-alphanumeric chars the better.
I know that there are some of my personal preferences talking now, but generally I prefer to read code as english-like sentences and having every single word in a separate line is far from readable. Yes, I can see the tokens and names and all, but these are out of context built by the line(s) above.
from heracles.ts.
https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L147
All arguments are neither in separate lines nor in a single one. I'd expected some consistency, either all arguments should span a separate line, or all should be side by side in single one (if still within the line length limit)
I agree. This seems to be a Prettier bug.
https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L155
Why simple arrow functions should have braces around argument? The less non-alphanumeric chars the better.
Looks like you discovered the most discussed Prettier issue.
As said before, if this annoys you too much let's just disable it for now. I like having consistently formatted code but it shouldn't get in the way of getting work done. We can always reformat the code later if we want to.
from heracles.ts.
I'll try to stick with it a little longer - yesterday I was really frustrated, but it was yesterday - I'll try to ignore it for a while and save/format once done.
from heracles.ts.
Related Issues (20)
- Not able to use Heracles.ts in my Project. HOT 5
- Consider renaming displayName to title HOT 1
- Get class property value HOT 2
- Question on status of spec and releases HOT 3
- Dependency Dashboard
- Don't mint blank node IDs unless absolutely necessary HOT 2
- Revisit extraction of "hypermedia" from resources HOT 1
- Extending from Arrays (Compatibility) HOT 3
- Apidocumentation instance set entrypoint property as undefined HOT 5
- Improve operation invocation API with IRI templates
- Obtaining whole collection HOT 1
- Are responses fully typed? HOT 7
- Document how to install and use Heracles.ts HOT 2
- correctly using heracles on a localhost HOT 6
- Links are to strict HOT 1
- Hypermedia lacks response headers HOT 1
- Consider compensation for missing entry point in API documentation HOT 1
- Cease support for memberTemplate HOT 1
- Add support for other RDF serializations
- Multiple API documentations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heracles.ts.