Coder Social home page Coder Social logo

Get rid of prettier about heracles.ts HOT 4 OPEN

hydracg avatar hydracg commented on June 19, 2024
Get rid of prettier

from heracles.ts.

Comments (4)

lanthaler avatar lanthaler commented on June 19, 2024

Prettier's default is 80 chars but it can be changed, see https://github.com/prettier/prettier#print-width. Is that the only issue you have with it? If not, what else bothers you? Some examples of formatting before and after might be useful.

from heracles.ts.

alien-mcl avatar alien-mcl commented on June 19, 2024

Well, there are a few issues:

https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L147
All arguments are neither in separate lines nor in a single one. I'd expected some consistency, either all arguments should span a separate line, or all should be side by side in single one (if still within the line length limit)

https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L155
Why simple arrow functions should have braces around argument? The less non-alphanumeric chars the better.

I know that there are some of my personal preferences talking now, but generally I prefer to read code as english-like sentences and having every single word in a separate line is far from readable. Yes, I can see the tokens and names and all, but these are out of context built by the line(s) above.

from heracles.ts.

lanthaler avatar lanthaler commented on June 19, 2024

https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L147
All arguments are neither in separate lines nor in a single one. I'd expected some consistency, either all arguments should span a separate line, or all should be side by side in single one (if still within the line length limit)

I agree. This seems to be a Prettier bug.

https://github.com/HydraCG/Heracles.ts/blob/master/src/DataModel/JsonLd/JsonLdHypermediaProcessor.ts#L155
Why simple arrow functions should have braces around argument? The less non-alphanumeric chars the better.

Looks like you discovered the most discussed Prettier issue.

As said before, if this annoys you too much let's just disable it for now. I like having consistently formatted code but it shouldn't get in the way of getting work done. We can always reformat the code later if we want to.

from heracles.ts.

alien-mcl avatar alien-mcl commented on June 19, 2024

I'll try to stick with it a little longer - yesterday I was really frustrated, but it was yesterday - I'll try to ignore it for a while and save/format once done.

from heracles.ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.