Color of graph based on value about leaflet-dvf

[sfairgrieve]

Good question. I haven't tried something like that before. Let me see if I can throw an example together that works. If I can't get it to work, I'll see what I can do about updating the codebase to make it work.

[sfairgrieve]

Here's a somewhat hacky example: http://humangeo.github.io/leaflet-dvf/examples/html/sochistats2.html. The other option would be extend one of the chart data layers (e.g. L.BarChartDataLayer) and override the _getMarker method. There you could update the options.chartOptions being passed to the L.BarChartMarker constructor to use the correct color based on value. That would probably be a better approach than the approach I'm using in the example above. Let me know if you have any questions about either approach. I'll think about updating chart data layers to make this easier in the future - appreciate any suggestions you might have.

[rickj33]

I needed the same functionality, So i started to extend the L.BarchartDataLayer and override the _getMarkerMethod, but there is an issue. In the L.ChartDatalyer and L.BarChartDataLayer the _getMarkerMethod override removes the record parameter. In the ChartDataLayer the _getLayer method calls the _getMarkerMethod but with out the record parameter even though the record object is passed into the _getLayer Method..
It would be very helpful to add the record parameter back into the _getMarkerMethod of the ChartDataLayer and BarChartDataLayer

The code i was looking at is in the 1.0Dev branch.

Thanks
Rick Jones

[sfairgrieve]

Good point. Thanks for pointing this out. The latest code should have this change in it.

[rickj33]

Thanks for responding so quickly.