Comments (4)
reviewit uses git show -s --format="%s"
to generate the subject line, for some reason git is saying that the subject is the whole thing, ignoring the line break, maybe because you used a colon at the end of the line.
from reviewit.
yes... it's exactly this, try git log --format=oneline
on this commit and you will see.
from git man page:
Though not required, itβs a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. The text up to the first blank line in a commit message is treated as the commit title, and that title is used throughout Git. For example, git-format-patch[1] turns a commit into email, and it uses the title on the Subject line and the rest of the commit in the body.
However I didn't find yet the rules git use to identify what's the subject.
I think a simple fix is just alert the user when the subject is greater than X (120?) characters, since a commit subject ending with ":" is also not good.
from reviewit.
ok.. thinking again, better to do this even simpler... forget about git and just get the first line, no matter how long it's, like you said.
from reviewit.
Fixed in commit b369348.
Thanks.
from reviewit.
Related Issues (20)
- If the branch name have a single single quote, it fails to re-apply. HOT 1
- Add a verbose mode to reviewit CLI
- Auto run `review cleanup` at least once a day (maybe 2) HOT 1
- `review apply` could apply multiples MR's
- Jira is not updated if we attach/update a ticket to the MR later. HOT 1
- Create an issue and pull request templates HOT 1
- Not is possible to add a comment in the code HOT 1
- "Remember me" Login not working HOT 2
- Implement web push notification HOT 1
- Notify other devices for all MR events HOT 2
- accept and cancel commands should also auto-detect the MR id. HOT 1
- Add a flag on CLI to enable MR creation on a dirty working copy. HOT 2
- Keep comments on unchanged lines between reviews HOT 3
- Diff view should be as wide as the project guidelines allow HOT 1
- Freeze some branches temporarily HOT 1
- Use a CSS based tool tip instead of the current JS based one. HOT 1
- Add abillity to reviewit to store default configs HOT 1
- Ability to use different git repositories for push and Gitlab CI
- Error 500 when checking pending tasks.
- Revert to an specific version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviewit.