Uglifyfy creates many blank spaces about uglifyify

[jamesreggio]

+1

This seems wrong.

[yoshuawuyts]

Hmh, that's odd. Does it cause any issues with source maps?

[naorye]

Not to me.

[TheLudd]

@yoshuawuyts I have noticed this as well, but only when I have source maps turned on. If I don't use source maps, the blank lines aren't there

[derekr]

Would it make sense to run a bundle that used uglifyify through uglifyjs?

[kristoferjoseph]

I'm seeing this as well.

[bholloway]

I believe this is caused by need for a line break before the source map comment.

In browserify the source map for each file is encoded as a trailing source map comment. This allows it to be passed between transforms without any additional data structure. When the browser-pack occurs, the comment is stripped from the individual files but the line break is not, leaving a blank line.

Unfortunately the line break is required for now. Browserify and its dependencies need to upgrade to convert-source-map@>=0.4.0 before the source map comment may be placed on the same line as the code.

This includes

• insert-module-globals/combine-source-map/convert-source-map
• browser-pack/convert-source-map.

[rahatarmanahmed]

What's the status of this issue? Both modules above are using a version of convert-source-map above 0.4.0.

[yoshuawuyts]

I'm not too fussed about this. From the docs:

When using uglifyify you should generally also use Uglify, to achieve the smallest output

If this is not causing any source map issues then I'm not particularly seeing a problem here. However if anyone does however feel inclined to submit a patch, I'd be happy to review it. Cheers!