Coder Social home page Coder Social logo

Comments (8)

guipenedo avatar guipenedo commented on July 30, 2024 1

maybe seconds will be more flexible for "softer" use cases

from datatrove.

guipenedo avatar guipenedo commented on July 30, 2024 1

We encounter them often, usually quite a lot of tasks fail (even with randomize start). We simply relaunch them afterwards.
I believe the requests from our cluster all come from the same IP, so I do not really have any recommendations on this

from datatrove.

guipenedo avatar guipenedo commented on July 30, 2024 1

Super interesting! Were these network speed improvements (to s3 I assume?) only during the beginning of the job (when each worker is listing all the files) or throughout it?

Also, what logs did you have in mind? Maybe you could add them to your upcoming PR?

from datatrove.

guipenedo avatar guipenedo commented on July 30, 2024

I think it's a good idea. Would you be interested in creating a PR for this change? Maybe randomize_start could become randomize_start_duration with a default value of 0 (disabled)

from datatrove.

justHungryMan avatar justHungryMan commented on July 30, 2024

Iā€™d be happy to create a PR for this change. Regarding the unit for randomize_start_duration, do you think it would be more appropriate to use seconds or minutes as the default unit of time?

from datatrove.

justHungryMan avatar justHungryMan commented on July 30, 2024

Regarding this issue, did you also encounter Too Many Requests errors while working with Common Crawl?

Iā€™m interested in determining the optimal number of multi-processing instances per IP to avoid hitting S3ā€™s limit. Could you share any insights or recommendations on this?

from datatrove.

justHungryMan avatar justHungryMan commented on July 30, 2024

Thank you for sharing your experience!

from datatrove.

justHungryMan avatar justHungryMan commented on July 30, 2024

@guipenedo

With the implementation of this feature and increasing the wait time, we've noticed a corresponding improvement in network speeds. It seems likely that there were existing bottlenecks due to excessive API calls. (wait time 180 -> 2500, network speed 180MBit/s -> 1.4GBit/s)

In light of this, it might be beneficial to include log messages that reflect these changes or provide guidelines for adequately setting the randomize_start_duration to prevent such bottlenecks.

And also I will do additional PR to examples/{some codes} for fixing randomize_start parameter, this weekend.

from datatrove.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.