Comments (2)
The envelope
is what is passed to adapters, ie:
Line 96 in a4c2ec8
You'd have to take a close look at adapters in the repo and in the wild to see what they are doing, and the difference. I don't remember if I was around when it was added, but my intuition would be to keep it a simple javascript object that is the interface, rather than passing message classes around. That might be moot though, since message
in turn is also included in it.
from hubot.
I see your point. The envelope contains the original message object, and since the envelope is the thing that gets passed around, that's how other objects can get the message. I'll review other adapters to see how and if it's being used in the wild.
I agree with your point about keeping it a POJO instead of codifying it as a Class. Hubot, in general, is a message connector between two systems, so it makes sense to "just pass it through".
from hubot.
Related Issues (20)
- Periodic unit test failure on Windows related to loading an adapter by file name
- Update the license HOT 6
- hubot-test-helper broke due to change to Robot constructor HOT 5
- Using Organization Scoped packages as adapters
- Roadmap. The march to `v10` HOT 4
- Upgrade from 7 to 9 causes: "Incorrect number of arguments for middleware callback (expected 1, got 3)" HOT 6
- Hubot Health/Monitoring HOT 11
- Using async calls in hubot scripts HOT 2
- Switch site to GitHub pages HOT 3
- Hubot doesn't respond to `@Hubot help`
- Web service test fails in Node.js 21 HOT 2
- Update some of the modules in the Hubot ecosystem HOT 1
- The road to v11, let's get Hubot caught up to the latest changes in Javascript and Node.js
- `./bin/hubot --help` doesn't work HOT 1
- Test failing on Windows HOT 1
- CoffeeScript removal is in v10.0.4 HOT 1
- Windows: Unable to load script file HOT 1
- Running hubot -a @hubot-friends/hubot-ms-teams fails HOT 1
- Testing Hubot with Express 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubot.