Migrate to procfs 0.12.0 about scaphandre

[eminence]

HI all, procfs maintainer here. I replied to @uggla in the issue over in my repo, but I figure I'd repeat it (and continue it) here.

The procfs API is not yet at 1.0, and so the API can still change in breaking ways.

The differences between 0.8 and 0.9 aren't that big, so I think you could remain on 0.8 if you wanted (there's actually only 1 bug fix between the two versions and I don't think you're impacted by it).

If you're concerned about the work involved, I would be happy to volunteer to do the upgrade for you, if you want.

Let me know what you think. Thanks!

[eminence]

My general recommendation is to upgrade to the latest procfs, but if you must remain on the v0.8.x release, then I'm happy to create a 0.8.2 that has eminence/procfs#152 cherry-picked. Just let me know

[uggla]

eminence/procfs#69 (comment)

[bpetit]

I'll have a look at that, as I'm working on some refactoring. I'll look into upgrading to latest procfs through that opportunity.

[bpetit]

Having a try with #144

Seems to work fine, feel free to run tests on your sides to.

[uggla]

It would be wise to ask the author of procfs if he has still plan to change/disrupt the api. If he considers the api stable enough then we could go ahead.

[bpetit]

You're right, we should start a discussion with them about that.

[bpetit]

Hi !

Thanks a lot for those informations. We will wait for the 1.0 then and ask you if we have issues with the upgrade :)

[rossf7]

Hey,
I ran into this while I was working on #143

The problem is the systemd cgroup driver for kubernetes uses : as a separator and the path gets truncated which means the container ID is missing. This was fixed in eminence/procfs#152

If I use a fork of 0.8.1 with just the fix it works great. Could we either upgrade or create a 0.8.2 patch release?

[rossf7]

Thanks I tested my changes in #143 with your changes in #144 and they worked fine.

[bpetit]

I think I found a bug in #144, don't rely on it too much yet. I'll try to document and fix that this week end.

[bpetit]

Bug is fixed. Merged this PR in the new dev branch. I'll work on #74, then merge in dev before merging everything to main.