"binary data not shown in terminal" appears with HTML response about httpie

[jkbrzt]

The Transfer-Encoding header shouldn't be a problem. Can you post an example URL where this happens?

[changemewtf]

Unfortunately it was an internal URL. I'll jimmy with the data a little and see if there's any other apparently relevant info I can add here.

[jkbrzt]

The binary data detection is based on the presence of \0. From the headers I can see that the response is UTF8-encoded HTML so it normally shouldn't be included. But maybe there are some garbled characters in the response?

In any case, it's not optimal that this happens, even if the data was garbled. I'll see what can be done to improve it.

[jkbrzt]

Actually, I think I've found the problem. Can you please try the URL with the current development version of HTTPie?

pip install -U https://github.com/jkbr/httpie/tarball/master

Btw, if the content that triggered the false positive isn't sensitive, it would be handy to have it available so that I can create a regression test for this issue.

[changemewtf]

D'oh... unfortunately the data has changed and I can't reproduce the issue with the stable release version anymore. Will hunt for a bit to see if I can get it to happen again on something similar...

[jkbrzt]

Please do. I realised that the change I just made is not significant in regards to the issue.

[jkbrzt]

Closing for now. Please feel free to reopen if the problem persists.