Comments (7)
Here is a file you can test it on (run it in a loop, it's pretty short):
from mpv-mpris.
Yes this is a known limitation of mpv-mpris. Only external album art is currently supported and the test file you provided uses an embedded image.
Although now that I think about it, it might be possible to use mpv's screenshot command to make this work. I'll have a play around with that when I have some time. PRs also welcome.
from mpv-mpris.
Is it a limitation of mpris protocol itself (i.e. it's impossible a normal way without such hacks like making a temporary external file), or mpv-mpris is just not implementing some features yet? How does it work for VLC for example?
I'd be interested in looking into it, if there is some correct solution.
from mpv-mpris.
mpv itself somehow recognizes that embedded image is a cover art and displays it. May be mpv-mpris can query that data from mpv itself? I'm looking through the code to try to understand what the plugin is doing now.
from mpv-mpris.
OK, I see it's doing try_put_local_art(mpv, dict, path);
now. I'll look into mpv itself, may be its library has some kind of function for getting the cover art or if not, I can open a feature request there. There is no need to duplicate that code.
from mpv-mpris.
Looking also into how VLC handled embedded cover image:
https://github.com/videolan/vlc/blob/master/modules/meta_engine/taglib.cpp#L780
https://github.com/videolan/vlc/blob/master/modules/meta_engine/taglib.cpp#L830
from mpv-mpris.
I'm not sure I understand it fully, but I think VLC reads base 64 encoded metadata, decodes into binary, and somehow handles that later. I.e. might be not even writing any file, just using the data from memory.
from mpv-mpris.
Related Issues (20)
- undefined symbol when run mpv with LD_DEBUG=libs
- i get this error spamed my log
- GLib-GIO-CRITICAL message spam when running mpv from terminal HOT 1
- Plugin doesn't work inside terminal. HOT 1
- Does not send an event on exit HOT 1
- Setting or defining seek distance HOT 2
- Can you add fullscreen status signals (true/false)?
- g_dbus_connection_register_object: assertion 'error == NULL || *error == NULL' failed HOT 6
- test failed because not pass `--no-config `
- Multiple delimiters for splitting artist field
- Position provided by Seeked signal inaccuracies
- Stops working after waking up from standby HOT 2
- Cover Image in notification HOT 1
- mpv-mpris not detected HOT 4
- How to make this work on Windows? HOT 1
- Could not load SO plugin: libavformat.so.58 HOT 1
- Can't detect installed libavformat HOT 3
- ffmpeg/demuxer warning after embedded cover art support HOT 4
- libavformat.so.58: cannot open shared object file: No such file or directory HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mpv-mpris.