Coder Social home page Coder Social logo

Image burn about ray-tracing-renderer HOT 3 OPEN

hoverinc avatar hoverinc commented on May 22, 2024
Image burn

from ray-tracing-renderer.

Comments (3)

jaxry avatar jaxry commented on May 22, 2024

Hi @ManishJu , thanks for describing the issue. I've run into the same bug before but it only happened rarely and inconsistently. Thankfully you figured out how to consistently reproduce it.

I loaded the scene on my computer, but the bug isn't appearing. It is probably hardware and scene dependent. But fortunately we might have a solution. I think this happens because of a division by zero in the reproject shader.

https://github.com/hoverinc/ray-tracing-renderer/blob/master/src/renderer/glsl/reproject.frag
If you replace both instances of sum > 0.0 with sum > 0.001 (or some other small number), does that fix the issue?

from ray-tracing-renderer.

ManishJu avatar ManishJu commented on May 22, 2024

No it does not solve the issue. I changed the 2 instances as you mentioned (even in different combinations) in that file and it did not work. The burn still starts after zooming in and out. Also I tested this on 3 browsers with stable build : Chromium, Firefox and Vivaldi and I still get the burn.

from ray-tracing-renderer.

ManishJu avatar ManishJu commented on May 22, 2024

I think I have found a way to reproduce it more elegantly .
In the test scene, try to get inside and out of any of the geometries (spheres or cuboids your choice). No need of new texture or changes that I posted. As soon as you get out the burn starts. Make sure only to zoom out. If you move the orbital camera a little along the horizontal axis the burn will stop . Is this because there is no light inside the geometries and the intersection test goes wrong when we come out of those geometries ?

from ray-tracing-renderer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.