Not in style guide: Use do end instead for multiline blocks in spec about hound

[gylaz]

Technically the code above does violate our style guide, since {} are for one-liners, or single line blocks.

[mrageh]

You can't use do end in this unless we add a description. How would you rewrite this to
be inline for our style guide?
Thanks in advance @gylaz

[gylaz]

You could do (the description is not necessary):

  it do
    should delegate_method(:default_variant_name).
      to(:default_variant).
      as(:name)
  end

Same could be said for expect {}:

expect do
  some_long_method_name_that_does_not_fit_on_one_line
end.to change { something }

# or
expect do
  some_long_method_name_that_does_not_fit_on_one_line
end.
  to change { something }

While I think the first example is fine, the second one is odd. But there isn't really a good solution for the second example without using {}, but then that's breaking consistency of our rules. This might be a good discussion for our guides repo.

[mrageh]

Thanks @gylaz, should I start a discussion in the guides repo or do people not mind using a it with no description and do end ?

[gylaz]

I think the conversation in guides would be helpful. We should probably figure out where to land with such blocks, especially in the expect situation.

[salbertson]

We can reopen the issue when a decision has been made.