Hound did not recognize my single line if statement as style problem about hound

[salbertson]

@Adam89, thanks for opening an issue.

[gabebw]

Yup, this is still an issue, just got this comment from @houndci:

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

That's definitely against our style guide.

[salbertson]

@gabebw, would you provide the code that Hound commented on?

[gabebw]

I'm not 100% sure (not my code, and a lot of commits since then), but I think this was it:

if signed_in? then redirect_to dashboard_path end

[salbertson]

@gabebw, thanks. Those comments won't be created anymore.

[mrageh]

Can we close this PR now?

[salbertson]

@Adam89, not yet because we aren't checking for ternary expressions yet. I opened a pull request for RuboCop to add the check for us to use.

rubocop/rubocop#1059

[Koronen]

@salbertson rubocop/rubocop#1059 was closed on Jun 12th. Maybe we could use the code from that PR as a custom cop that we either release as a gem, or just ship with Hound?

[gylaz]

@Koronen That PR was merged into RuboCop, but there's a flaw with that cop. We should submit a PR upstream fixing it.

[thorncp]

Looks like there has been no progress on this. To summarize the outcome of rubocop/rubocop#1059, the OneLineConditional, MultilineTernaryOperator, and TernaryOperator cops should be merged into a single cop with the 3 alternate styles. Anyone willing to take that on?

[thorncp]

Closing for inactivity.