Firefox Hello icon broken about arc-firefox-theme

[horst3180]

is that Firefox 40?

[lucaswerkmeister]

42, current Developer Edition

On 22.09.2015 15:33, horst3180 wrote:

is that Firefox 40?

—
Reply to this email directly or view it on GitHub
#24 (comment).

[horst3180]

I'll create a branch for Firefox 42 beta and sync with the latest changes.

[lucaswerkmeister]

So this doesn’t happen in Firefox 40?

[horst3180]

No, it doesn't happen in 41 either. It has to be a change introduced in 42.

[horst3180]

I created a branch for Firefox 42: https://github.com/horst3180/arc-firefox-theme/tree/firefox-42-beta
To test this, you have to checkout this branch and generate the .xpi files yourself as described in the readme, i.e

git clone https://github.com/horst3180/arc-firefox-theme && cd arc-firefox-theme
git checkout firefox-42-beta
./autogen.sh --prefix=/usr
make mkxpi

[lucaswerkmeister]

Seems to work, thanks! (Also fixes a problem with the Sync row in the menu.)

[lucaswerkmeister]

Oh, I found another problem: The “tab audio” icon (see Bug 486262) always takes up space, and when clicked also becomes visible, even for tabs that don’t play audio. This is especially noticeable for pinned tabs, which are almost twice as wide as they should be.

[horst3180]

It should work now (8535b34).

Tested with 42.0b1 and 43.0a2.

[lucaswerkmeister]

Great, thanks!