Running out of heap when no Google Home is found about esp8266-google-home-notifier

[skezo]

Doing a bit more digging on this. The memory leak happens at any point no Google Home device is found. For example if you run the ghn.device(displayName) once in the initial setup() function using a displayName that is not on the network the mDNS lookups (ESP8266mDNS.cpp/h) will continue to search for it after the timeout from esp8266-google-home-notifier.cpp/h.

Code sample:

...
void setup() {
  Serial.begin(115200);
  WiFi.mode(WIFI_STA);
  WiFi.begin(ssid, password);
  while (WiFi.status() != WL_CONNECTED) {
    delay(500);
  }
  Serial.println("connecting to Google Home...");
  if (ghn.device(displayName, "en") != true) {
    Serial.println(ghn.getLastError());
    return;
  }
  Serial.print("found Google Home(");
}
void loop() {
}
...

[skezo]

The issue seems to be cause by GoogleHomeNotifier::device repeating to call to MDNS.begin(hostString) in ESP8266mDNS.cpp.

[horihiro]

Thanks!