Coder Social home page Coder Social logo

Comments (3)

yusukebe avatar yusukebe commented on September 21, 2024

Hi @ivandotv

What is the reasoning behind that decision?

This is to keep the implementation simple. If it allows multiple handlers, the type definition will be very, very complex.

Instead, you may use a Hook:

app.openapi(
  route,
  (c) => {
    const val = c.var.val
    return c.json()
  },
  (result, c) => {
    if (result.success) {
      c.set('val', 'foo')
      // auth
    }
  }
)

from middleware.

ivandotv avatar ivandotv commented on September 21, 2024

I believe breaking the middleware contract to have a type inference on the default handler is not worth it.
Open API can also have multiple responses, and putting that logic in one giant function will not work and will not scale.

Breaking the middleware contract (which is used in the original Hono, and other frameworks) is a bad decision

In the end I took the underlying zod-to-openapi package and did the implementation from scratch, respecting the middleware order.

Feel free to close this issue.

from middleware.

yusukebe avatar yusukebe commented on September 21, 2024

Breaking the middleware contract (which is used in the original Hono, and other frameworks) is a bad decision

Regarding this "Zod OpenAPI Hono", our first idea is to implement OpenAPI with keeping the RPC feature. So we can't avoid that don't support multiple handlers.

In the end I took the underlying zod-to-openapi package and did the implementation from scratch, respecting the middleware order.

It's a good idea. I think you don't need to use this Zod OpenAPI Hono.

Thanks. Closing the issue.

from middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.