Type identifying problem about homebrew-cask

[phinze]

We're still tuning the filetype identification. Since filenames suck for this, we look for output in file -Izb to determine what to do.

Apparently we're not parsing the following properly:

$ file -Izb textadept_6.0_beta_3.osx.zip 
application/x-empty compressed-encoding=application/zip; charset=binary; charset=binary

[phinze]

Weird, over here:

https://github.com/phinze/homebrew-cask/blob/master/lib/cask.rb#L202

We're looking for:

output.chomp.include? 'compressed-encoding=application/zip; charset=binary; charset=binary'

Which should yield true.

I'll look into this more later tonight and follow up.

[phinze]

Oh I bet it's the space in the version. Try 6.0-beta-3 and see if that fixes it for you.

[rgieseke]

Alright, this works:
version '6.0-beta-3'

Thanks for looking into it!

[program247365]

@phinze

For firefox-aurora, I get:

uh oh, could not identify type of /Library/Caches/Homebrew/firefox-aurora-17.0a2 (210912).dmg

Similar issue?

[phinze]

I just cut v0.3.2 which should handle spaces properly everywhere.

Can you let me know if this solves the problem for you? Seems to work for firefox-aurora here.

[phinze]

Gonna go ahead and close this - pretty sure everything is working here. Feel free to reopen if there are additional issues to work out.

[program247365]

@phinze Oops, sorry. Yes, it did indeed fix it for me. Thanks.