Comments (9)
skipping these stanzas (uninstall quit, and uninstall signal) was a recent change, because apps such as Visual Studio Code should not be forcibly closed as it is likely to cause a loss of work. And we were seeing an increase in PRs to add the stanzas.
Adding the ability to specify that the stanza should fire on upgrade makes sense to me, but the criteria for when this should apply could be difficult to determine. I would suggest that the loss of work is the item that matters most.
from brew.
Here's the related PR: #16507
from brew.
Seems reasonable to me but defer to @Homebrew/cask folks.
from brew.
Adding the ability to specify that the stanza should fire on upgrade makes sense to me, but the criteria for when this should apply could be difficult to determine.
Opt-in with a new DSL makes sense to me here.
What happens on uninstall
?
from brew.
On uninstall we do run the quit and signal directives, but not on upgrade or reinstall.
from brew.
@bevanjkay Gotcha. Could you dig up the PR that changed this, too?
from brew.
Thanks @bevanjkay. Yeh, I think a new DSL/parameter is warranted here.
from brew.
Can you think of an existing dsl that has a similar parameter I can use as a guide?
from brew.
@bevanjkay depends_on
I think is the best model here? It may be more complicated than you need, though. Feel free to hack something together and open a very early draft WIP PR and I'll help you from there 👍🏻
from brew.
Related Issues (20)
- Homebrew is broken on Debian running under WSL2 HOT 1
- `Error: bad URI(is not URI?):` when search item contains a space HOT 1
- Support TunSafe: https://github.com/TunSafe/TunSafe/tree/release/1.4
- `TypeError: Parameter 'cmd': Expected type String, got type Pathname with value`
- cmake ninja dfu-util HOT 2
- brew.sh website not accessible from the Philippines HOT 3
- Error: failed to fetch attestations from trailofbits/homebrew-brew-verify: HTTP 401: Bad credentials HOT 5
- Documentaion: How-To-Open-a-Homebrew-Pull-Request.md - add cleanup instructions HOT 1
- Documentaion: How-To-Open-a-Homebrew-Pull-Request.md - missing info about `brew create` HOT 1
- brew link against non-existing formula causes uninitialized constant error HOT 2
- Investigate resource-ification of Rust dependencies with `cargo vendor` HOT 2
- getpwuid function doesn't work with LDAP users on Linux HOT 1
- Formula auditor's Formula version check falls through to Resources version check
- Make a RuboCop to recommend `bin/"foo"` over `"#{bin}/foo"`
- systemd brew.rb "Error: no implicit conversion of false into String" error HOT 6
- Push `latest` tag for bottles HOT 3
- Create self-describing bottles HOT 6
- Rosetta 2 caveat is shown on Intel Mac HOT 6
- brew --repository now prefixes "homebrew-" to tap directory
- Could not update to 4.3.10 HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brew.