inconsistent dialog width about frontend

[balloob]

It happens because the first time the history API is not loaded yet.

On Mon, May 16, 2016 at 9:34 AM, Roi Dayan [email protected] wrote:

this happens with any dialog. for example i chose humidity. opening and
closing the dialog gives different width each time. to be more precise it
can be one of 2, narrow or wider. so each time it's one of the two.

wider
[image: screenshot_4]
https://cloud.githubusercontent.com/assets/660126/15296176/c6b82822-1b9c-11e6-8b13-ffe42cd3d2ee.png

narrow
[image: screenshot_5]
https://cloud.githubusercontent.com/assets/660126/15296178/c8643cec-1b9c-11e6-955d-6d5b901a725f.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#60

PaulusSchoutsen.nl
It's nice to be important but it's more important to be nice.

[roidayan]

But it continue to happen again without refreshing the page. Just closing and reopening the dialog.
It only happens on desktop view btw.
On tablet view the dialog keeps the same size though the graph is narrow or wide inside.

[michaelarnauts]

I still see this in the latest code in dev. Opening and closing the same popup a few times in a row can give a different sized popup. I didn't resize or move my browser window.

[justweb1]

@roidayan Are you still experiencing this issue?

[michaelarnauts]

This is still occurring on 0.29.5.

[justweb1]

@roidayan @michaelarnauts I'm only seeing this issue in modals that have state-history-chart-line. Are you seeing it anywhere else?

[roidayan]

I currently have an issue that I see the loading circle all the time and get an error that the sqlite db is busy. so I can't see any state history for any sensor. I'll try to check why and see if I get it in other state history charts.

[roidayan]

I also notice this in state-history-chart-timeline

[justweb1]

@roidayan @michaelarnauts Please help me test this because it is an intermittent issue.

[justweb1]

What browsers are you experiencing this issue on?
Are you still experiencing it in 0.30.1?

[michaelarnauts]

I always use Chrome, and it also occurs on the mobile version (Android).
Last tested version is 0.29.5.

Op zo 9 okt. 2016 15:21 schreef Justin Weberg [email protected]:

What browsers are you experiencing this issue on?
Are you still experiencing it in 0.30.1?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABI3MxRYSs8CxBJ5cZRI7n8ytetgihb8ks5qyOpCgaJpZM4Ife1o
.

Michaël Arnauts

[roidayan]

I also use chrome. Tested desktop and mobile on Android. I run 0.29.7.
I haven't tested the suggested css fix yet nor 0.30.1.

On Sun, Oct 9, 2016, 17:10 Michaël Arnauts [email protected] wrote:

I always use Chrome, and it also occurs on the mobile version (Android).
Last tested version is 0.29.5.

Op zo 9 okt. 2016 15:21 schreef Justin Weberg [email protected]:

What browsers are you experiencing this issue on?
Are you still experiencing it in 0.30.1?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#60 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABI3MxRYSs8CxBJ5cZRI7n8ytetgihb8ks5qyOpCgaJpZM4Ife1o

.

Michaël Arnauts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoSnof4Gx-EHBjuVRJBKFP35dJSKjtcks5qyPXGgaJpZM4Ife1o
.

[justweb1]

It is happening on mobile too?

[roidayan]

Yes

On Sun, Oct 9, 2016, 20:26 Justin Weberg [email protected] wrote:

It is happening on mobile too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoSnvuCGZrBCdQVK78aN_UBQK8sUNTpks5qySOvgaJpZM4Ife1o
.

[michaelarnauts]

Indeed, but there, the effect is different. The dialog always opens full
width, but the contents is too wide sometimes.

Op zo 9 okt. 2016 19:27 schreef Roi Dayan [email protected]:

Yes

On Sun, Oct 9, 2016, 20:26 Justin Weberg [email protected] wrote:

It is happening on mobile too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#60 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAoSnvuCGZrBCdQVK78aN_UBQK8sUNTpks5qySOvgaJpZM4Ife1o

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABI3M8nJ6Hv5E371DiLw70y1ozt6hlmtks5qySQWgaJpZM4Ife1o
.

Michaël Arnauts

[justweb1]

Check out the PR for a fix for the desktop. I'll have to look more into mobile.

[roidayan]

In mobile the dialog has css width 100% I think so it always fits the
screen and in desktop width is auto so it fits according to the chart width.
I'll be able to check also the pr tomorrow.

On Sun, Oct 9, 2016, 23:05 Justin Weberg [email protected] wrote:

Check out the PR for a fix for the desktop. I'll have to look more into
mobile.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoSnjRJyDjJjyr7GaIjDrTqDbrPsVQCks5qyUkfgaJpZM4Ife1o
.

[justweb1]

I'm not worried about mobile just yet. I will fix it but first I want to make sure the desktop version is fixed before I move on. I am not having any issues with inconsistency.

[justweb1]

Also set max-width on history-charts to fix mobile issue #120

[michaelarnauts]

Two screenshots on mobile. See the width of the timeline. Above is correct. The page seems to chose randomly between the two versions.

[justweb1]

Are you able to test the PR? I believe both issues are now fixed.

On Mon, Oct 10, 2016, 7:26 AM Michaël Arnauts [email protected]
wrote:

[image: screenshot_20161010-142253]
https://cloud.githubusercontent.com/assets/1193779/19235982/2f578366-8ef5-11e6-838d-40327e6da1dd.png

[image: screenshot_20161010-142247]
https://cloud.githubusercontent.com/assets/1193779/19235988/373ad8d0-8ef5-11e6-9f91-c5950738717e.png

Two screenshots on mobile. See the width of the timeline. Above is
correct. The page seems to chose randomly between the two versions.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKvitYHVDELuzq7qCW8eWbo1Gn6wrO8_ks5qyi7kgaJpZM4Ife1o
.

[justweb1]

Fixed #120

[michaelarnauts]

I'm afraid this isn't fixed. See attached screenshot of version 0.31.1. Switches randomly between this state, and the correct state.

Bad:

Good:

[michaelarnauts]

@justweb1 could you re-open this issue?

This still happens in release 0.34.2

[justweb1]

@michaelarnauts what browsers do you see the issue in?

[michaelarnauts]

Chrome (54) and Firefox (50). The dialog width itself seems to be the same (365px), but the svg sometimes renders at 400px wide.

[justweb1]

Part of the problem is that component uses external scripts and at some point should be rewritten completely using the available Web component.