Comments (8)
It seems there is an issue with the padding/margin anyway, as the "ripple effect" seems to be cut off.
This doesn't happen on the demo pages: https://elements.polymer-project.org/elements/paper-toggle-button?view=demo:demo/index.html&active=paper-toggle-button
from frontend.
The padding has been increased in 0.17. You removed the issue template so I
don't know which version you're running. The cutting off is only in the
more info which doesn't have any side effects.
On Wed, Apr 13, 2016, 03:13 Michaël Arnauts [email protected]
wrote:
It seems there is an issue with the padding/margin anyway, as the "ripple
effect" seems to be cut off.
[image: image]
https://cloud.githubusercontent.com/assets/1193779/14490079/f223d63c-0170-11e6-8ae2-e7e3c04f2f70.pngThis doesn't happen on the demo pages:
https://elements.polymer-project.org/elements/paper-toggle-button?view=demo:demo/index.html&active=paper-toggle-button—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#49 (comment)
from frontend.
There is no issue template in this repo :)
Anyway, I just upgraded to 0.17, and the padding around the toggle seems to be padding: 9px 0;
. If I change this to padding: 9px;
, it's a lot better to click on the icon, and the layout doesn't seem to change.
Edit:
On this line: https://github.com/home-assistant/home-assistant-polymer/blob/4ab308a9d2ae8a5f7313a28f333fd0636c94968f/src/components/entity/ha-entity-toggle.html#L20
from frontend.
Ah my bad, I thought this was an issue on the main repo.
I did explore this when I decided to just add a padding on top + bottom. Adding a padding on the right would make the switch not align with control for other entities. And since we can't have a padding on the right we also can't have a padding on the left or else it's not symmetrical.
from frontend.
I have about a 50% success rate when toggling a switch on mobile. Too easy to accidentally open the graph.
from frontend.
@balloob Can this issue be closed or should we still look into it?
from frontend.
I still have the same remark as @happyleavesaoc . On mobile, I accidentally open the dialog a lot instead of toggling the switch.
from frontend.
This can be solved by increasing padding (Google recommends at least 48x48: https://developers.google.com/speed/docs/insights/SizeTapTargetsAppropriately)
and compensating for it with negative margin. This way it doesn't move the element and doesn't affect parent size.
from frontend.
Related Issues (20)
- plural and singular are swapped for condition matching display HOT 1
- Red exclamation mark icon when a custom integration helper is created in helpers overview HOT 3
- "Add New badge" tooltip in French HOT 1
- TP-Link Missing Main Integration Entry HOT 5
- "Trace Timeline" throws exceptions for `repeat` action HOT 5
- Energy distribution graph is inaccurate without solar production HOT 2
- Thermostat Card: +/- Buttons Removed Upon Resizing HOT 4
- Webkit errors in sections HOT 1
- Cannot load views with type "section" via handy HOT 2
- Inconsistent Capitalisation of Relative Time in Badges
- Bright white lines in tables
- HA getting very slow reaction using iOS Safari.
- CalDAV times all wrong
- Badges do not respect unit of measurement HOT 4
- Entities using decimal numbers cause slowness and crashing on iOS
- Italian translation / UI error with Sun time condition HOT 1
- Back button doesn't work in browsers/companion apps after vewing a more info panel HOT 1
- Adding entities to a group which has an area different to the parent shows those entities in the wrong area when using Jinja
- Missing translation "Proud part of"
- Missing translation "not everything will be available until it is..."
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend.