Coder Social home page Coder Social logo

Comments (8)

johnconn73 avatar johnconn73 commented on September 23, 2024

I agree. It'd be great to have a more compact view of each of the SONOS widgets, too. BTW, I think the behaviour above is across all SONOS devices. I have a Playbar, Play3 and a Play5 and they all present as @arsaboo describes with large white panels above - regardless of what's playing or not. I think a more horizontal display would be preferable so it takes up less vertical space ie cover art placeholder to the left, controls to the right?

from frontend.

arsaboo avatar arsaboo commented on September 23, 2024

As I recall, @bjarniivarsson's original intent behind these large boxes was to give enough space to the album art. Unfortunately, when when there is no album art, these large empty boxes look ugly.

from frontend.

johnconn73 avatar johnconn73 commented on September 23, 2024

Understood. And that makes sense for many. Perhaps alternative displays for those that need more or less cover art visible. Cover art is a nice touch, but for me it's more important to know just what is playing and where rather than how the album art looks. I really should learn to develop so I can contribute...

from frontend.

bjarniivarsson avatar bjarniivarsson commented on September 23, 2024

That you are getting a white box instead of album art is definately a bug. The white background should only appear if there is some album art to display on top of it (otherwise you should get a blue background with an icon). As I don't have a SONOS device with a line in (only have Play 1/3 speakers) it is hard for me to test, but I have a pretty good idea how to fix this, will have a look tonight.

Regarding the size of the player, I't should show as more compact when not playing music (and when no album art is available). I did think about solutions where the album could be on the left, with album info/controls on the right, but one of the problems is that some media players have wider album art (video players). I'll play around with the HTML/CSS, but I think it will be hard to find something that everyone is happy with.

from frontend.

arsaboo avatar arsaboo commented on September 23, 2024

Thanks @bjarniivarsson!!

from frontend.

mihalski avatar mihalski commented on September 23, 2024

How about a view with no album art at all as an option? I noticed that this is exactly what I get when the Sonos Playbar is in TV mode.

Just something like:

album_art: false

My Yamaha A/V Receiver seems to have this compact view without album art by default.

from frontend.

mihalski avatar mihalski commented on September 23, 2024

FWIW:

media_players

from frontend.

balloob avatar balloob commented on September 23, 2024

This is not a bug in the frontend but in the Sonos platform. As @bjarniivarsson notes, the component should not show any album art if there is none. This is what can also be observed in the code here: https://github.com/home-assistant/home-assistant-polymer/blob/master/src/cards/ha-media_player-card.html#L278-L279

The bug with Sonos is that when it doesn't have album art, it should return None from property media_image_url.

Closing this as it is not frontend related.

from frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.