Coder Social home page Coder Social logo

Comments (7)

synesthesiam avatar synesthesiam commented on August 16, 2024 1

@dferrante The area requirement should be removed now, but setting a timer requires some way of notifying the user when it's done. For mobile, we're considering push notifications.

@weberruss Voice timers are separate from existing HA timers.

from core.

dj-sf avatar dj-sf commented on August 16, 2024

brief update -- i tried labeling my devices with an "area" to see if this made a difference. it did not.

from core.

dj-sf avatar dj-sf commented on August 16, 2024

After some tinkering locally, I've discovered a few things.

  1. The default HassStartTimer intent initially does not match due to the missing "area" property when running from web client (breakpoint stops here revealing "area" listed in maybe_result.unmatched_entities.)
  2. When using the custom version of that intent without the Area requirement ( see timers.yaml from original post) , the error being thrown is the TimersNotSupportedError on line 815 of the dev branch. This is because it fails the logic check that occurs immediately beforehand -- conversation_command & intent_obj.device_id are both None, and the device, not having an id, is not registered with the timer_manager.

Therefore, I'd like to propose some possible fixes:

First, we should either remove the area requirement from the default intent OR give the clients some sort of placeholder area value so that requirement is fulfilled.

Second, we should either modify the default attributes of the web & mobile clients so that they can pass this logic check out of the box OR we should change this logic to allow them to use the timer intents with their current attributes.

@synesthesiam I see that you have worked on the timer logic quite a bit. Do you know if any of these proposed solutions might work?

from core.

weberruss avatar weberruss commented on August 16, 2024

It should be also possible to start, stop, ... already existing timer with their default duration entities in HA with a sentance like "start timer {timer_name:name}" so the timer duration needs to be an optional parameter.

from core.

freeDom- avatar freeDom- commented on August 16, 2024

@dferrante The area requirement should be removed now, but setting a timer requires some way of notifying the user when it's done. For mobile, we're considering push notifications.

@weberruss Voice timers are separate from existing HA timers.

Mobiles do have a speaker to notify the user when the timer is expired. You can already send tts notifications to yohr mobile phones. I am just wondering why mobile phones then are treated differently..?

from core.

JeroenVandezande avatar JeroenVandezande commented on August 16, 2024

I also don't understand the reason that only devices that made the timer can notify the user.
Something I hate with my Google homes atm is I make a timer in the kitchen (e.g. something in the oven for 20 minutes)
and then I work in the homeoffice.. it would be great it the Google Home could notify me there, or on my phone or whatever... no it starts making noise in the kitchen while I am not even there...
I could see times like this:
"Please create a timer for 20 minutes then blink the lights in the home office"

from core.

freeDom- avatar freeDom- commented on August 16, 2024

I also don't understand the reason that only devices that made the timer can notify the user. Something I hate with my Google homes atm is I make a timer in the kitchen (e.g. something in the oven for 20 minutes) and then I work in the homeoffice.. it would be great it the Google Home could notify me there, or on my phone or whatever... no it starts making noise in the kitchen while I am not even there... I could see times like this: "Please create a timer for 20 minutes then blink the lights in the home office"

This should be possible with sth like:

Blink the office lights in 5 minutes

I am not sure if blinking is supported out-of-the-box or whether you need a custom automation, script or intent for this, but I tested "Turn on the office light in 10 seconds" and it works.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.