Coder Social home page Coder Social logo

Comments (12)

home-assistant avatar home-assistant commented on July 20, 2024

Hey there @tronikos, mind taking a look at this issue as it has been labeled with an integration (google_assistant_sdk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant_sdk can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign google_assistant_sdk Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


google_assistant_sdk documentation
google_assistant_sdk source
(message by IssueLinks)

from core.

databoy2k avatar databoy2k commented on July 20, 2024

Can confirm; the "target" portion of the data causes the command to not send. Deleting any "target" data causes the message to send immediately.

Test string (you will almost certainly need to alter "target" to your own rooms, but you can also delete the "target" portion entirely afterwards)
service: notify.google_assistant_sdk data: message: > Looks like the dog and fish have been fed. You guys rock! target: - Living Room - Kitchen - Media Room - Play Room

I checked the "My Activity" on Google (https://myactivity.google.com). When it was working (e.g. 2024-05-23) I would get the following, e.g.:
image
(I should note that this was one of 4 identical, except for the room. It appears that the integration cycles through the targets and sends a separate broadcast to each target)

Compare to today:
image

Note how it doesn't say what the message was (this is one of the ones with a "target" that didn't work). It must have been malformed from the start because for whatever reason the Assistant doesn't actually get the message itself.

I have zero idea how to get logs from the Cloud Console; happy to turn on logging if someone can walk me through it.

from core.

smarthomefamilyverrips avatar smarthomefamilyverrips commented on July 20, 2024

@databoy2k yes indeed it works without target, in my case the target part is the most valuable part as not need my announcements be made through whole the house... probably this is a problem on google's end as also it not works if I ask google to broadcast a message to kitchen, it says that there is no device named kitchen while my Nest Mini located in kitchen area is called Kitchen, but being that Google not really cares about its end consumers it will be just guessing and hoping when and if this get fixed (similar it not let me stream new generation nest cams to my hub devices by voice command if the command is not been given on the hub where I want ro stream the camera to, this also already is a issue for 1.5 year if not more)

For now I switched to TTS in HA to announce messages to the media_player devices in the areas relevant for me.

EDIT: by the way 23-05-2024 was last day for me (also) that it still was working.

from core.

databoy2k avatar databoy2k commented on July 20, 2024

probably this is a problem on google's end as also it not works if I ask google to broadcast a message to kitchen, it says that there is no device named kitchen while my Nest Mini located in kitchen area is called Kitchen...
For now I switched to TTS in HA to announce messages to the media_player devices in the areas relevant for me.

Fair enough. For what it's worth, I just manually tested using another google device. I just said, "Broadcast to the Play Room, this is a test" and only the play room received that broadcast.

I think our issue here is that the way that the integration sends the broadcast requests is getting malformed somehow thanks to a change on Google's end.

I use the SDK because we're almost always playing music in our house through the speakers, and the broadcast continues the music after sending the message. So I'm in a bit of a "do I just broadcast to the whole house or do I interrupt the music" situation. My hope is that my confirmation can help it get fixed by someone way smarter than me.

from core.

smarthomefamilyverrips avatar smarthomefamilyverrips commented on July 20, 2024

probably this is a problem on google's end as also it not works if I ask google to broadcast a message to kitchen, it says that there is no device named kitchen while my Nest Mini located in kitchen area is called Kitchen...
For now I switched to TTS in HA to announce messages to the media_player devices in the areas relevant for me.

Fair enough. For what it's worth, I just manually tested using another google device. I just said, "Broadcast to the Play Room, this is a test" and only the play room received that broadcast.

I think our issue here is that the way that the integration sends the broadcast requests is getting malformed somehow thanks to a change on Google's end.

I use the SDK because we're almost always playing music in our house through the speakers, and the broadcast continues the music after sending the message. So I'm in a bit of a "do I just broadcast to the whole house or do I interrupt the music" situation. My hope is that my confirmation can help it get fixed by someone way smarter than me.

Yes the interruptions are indeed the downside if you use TTS, I just tryed again to ask google assistant on my phone to broadcast a message to Kitchen but at me get the same error as described before.

Screenshot_20240527_184955_Google

from core.

smarthomefamilyverrips avatar smarthomefamilyverrips commented on July 20, 2024

@databoy2k after trying a bit more it seems that it only affects my Nest Mini's, if I ask Google Assistant to broadcast a message to my Hubs or Hub Max it does work.

from core.

databoy2k avatar databoy2k commented on July 20, 2024

As far as I'm aware, "Target" refers to rooms as defined in your Google Home app. So, the "Playroom" in my case refers to a Google Home that is called the "Play Room Home" but could be named any name as long as it's associated with the room.

Try to add your minis to rooms (e.g. kitchen) even if it's the only device in that room.

Still doesn't change the fact that the request is being misformed in some way if targets are defined in the command. Sadly, this is as far as I can take it but I hope that one of the coders actually takes a look at this.

from core.

smarthomefamilyverrips avatar smarthomefamilyverrips commented on July 20, 2024

As far as I'm aware, "Target" refers to rooms as defined in your Google Home app. So, the "Playroom" in my case refers to a Google Home that is called the "Play Room Home" but could be named any name as long as it's associated with the room.

Try to add your minis to rooms (e.g. kitchen) even if it's the only device in that room.

Still doesn't change the fact that the request is being misformed in some way if targets are defined in the command. Sadly, this is as far as I can take it but I hope that one of the coders actually takes a look at this.

Yes you are correct, targets are areas within Home Assistant, and normally it will play the broadcast to all suitable devices in that area. I have all my devices located in areas/rooms as well in Home Assistant and also in the Google Home App, as said till 23rd May all was working fine, and the sdk_send_command service also still works as expected at the moment.

Indeed only choice for now is waiting for one of the coders and hopefully they come with a solution.

from core.

genestealer avatar genestealer commented on July 20, 2024

I can confirm I have the same issue.

Specifying a target room only works when Google Assistant SDK has it's language set to "en-US"
image

Changing it to any other language makes it so nothing is broadcasted, if a target is set, including en-GB.

NOTE: This stopped working a few months ago, it used to work just fine before that.

If I set the language to "en-US" it works, but I get an American voice doing the broadcast!

from core.

smarthomefamilyverrips avatar smarthomefamilyverrips commented on July 20, 2024

I can confirm I have the same issue.

Specifying a target room only works when Google Assistant SDK has it's language set to "en-US" image

Changing it to any other language makes it so nothing is broadcasted, if a target is set, including en-GB.

NOTE: This stopped working a few months ago, it used to work just fine before that.

If I set the language to "en-US" it works, but I get an American voice doing the broadcast!

@genestealer good catch on the language thing πŸ‘ I had mine on en-CA, changing it to en-US makes it work for me also again. Only I not recognize your remark that it stopped working Months ago at me it worked fine untill 23rd of May with language set to en-CA.

from core.

dw1562 avatar dw1562 commented on July 20, 2024

I have tried setting the language to en-US and also removing the targets so it just goes to all devices. No luck. It's still not working. It had been working fine for months.

from core.

smarthomefamilyverrips avatar smarthomefamilyverrips commented on July 20, 2024

I have tried setting the language to en-US and also removing the targets so it just goes to all devices. No luck. It's still not working. It had been working fine for months.

@dw1562 Without setting targets here it works fine on any language, using targets only works when changing from en-CA to en-US

From the sound of it seems a different issue at you if it not works at all, your google_sdk_command service does still work? Maybe your Google Assistant SDK integration not works at all?

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.