Coder Social home page Coder Social logo

Comments (3)

balloob avatar balloob commented on July 25, 2024

I don't think that adding IP address is a good idea.

From what I think why, you want to add it to allow the user whitelist feature. However, adding an IP address to EVERY context ever for the sake of 1 auth provider is a hard no from me.

The only thing I might consider is refresh token ID, as that will allow us to point at which device was used. However, we don't have a use case right now and I think that we should first make context more widespread (including recorder/ store/restore) before adding new data.

from architecture.

awarecan avatar awarecan commented on July 25, 2024

My intention is to support trusted network auth provider, but I think that may help to audit log as well, so that we can tracking who did what at when from where.

Anyway, it would not be a road blocker for me, I can use other way to make trusted networks auth provider works.

from architecture.

balloob avatar balloob commented on July 25, 2024

No longer needed.

from architecture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.