Comments (7)
I remember that we had a similar discussion when image processing was introduced. I think that one of our thoughts was that we don't want to become a full image detection pipeline. By keeping it simple, we can enable some use cases and still keep it fairly simple.
Right now we can enable a motion detector to trigger reading a camera and seeing who is there for example.
For continuous screen detection I would expect that to happen outside HA and we only receive events of things that are discovered.
from architecture.
OK, we don't want feature creep, lets scratch image_processing pipelines off.
I'm not talking about continuous screen detection, I'm just talking about getting the image that was processed by a current image_processing platform:
- Face is detected
- We get the image where the face was detected (not a new one)
Does extending image_processing to supply an Image make sense ?
from architecture.
Would a PR to add SINK entity to image_processing be accepted ?
SINK would be a camera entity (would also issue a PR for a sink_camera that can receive images)
from architecture.
My previous proposal would create a circular dependency between image_processing and camera.
- Image Processing should be a proper service, without any dependency on camera component. Ideally you would have a queue to receive images, and a queue with processed images.
But I also see a second opportunity:
-
Notifications that include images, have the images passed around through the filesystem (very bad when you are running on an RPi3). It would be interesting to also share images with Notification System.
-
Passing images through the event bus will just through hundreds of kbytes through the bus (requiring conversion of binary images to base64 for json serialization).
To tackle all these issues, my proposal would be for the development of a blackboard for images. The blackboard could live in hass.data.
I have no problem diving into coding this solution, just would like some feedback beforehand.
from architecture.
I don't know much about the architecture here but do you really need to pass along the image? Can't you extend camera component to keep its own queue instead? And image processing would consume event and use image? Possibly with a lock to not clean image during processing. Alternatively some other place that can consume and keep images decoupled from both camera and processing
from architecture.
@Kane610 your first proposal would still create a dependency between components (instead of moving to a decoupled solution)
"other place" is my proposal :)
from architecture.
Allright, maybe I misunderstood :)
from architecture.
Related Issues (20)
- Splitting tests files in smaller files in components/modules tests HOT 1
- Feature Request HOT 1
- Add favorite position to Cover entity HOT 10
- Add feature light distribution control to LightEntity
- Add new CURRENT_HVAC constants HOT 1
- Add Home Appliance entity
- Officially allow enities to set their entity ID not based on their names HOT 2
- Custom Device Class for Binary Sensors HOT 9
- Installed homeassistant supervised on my Linux machine; can't get it to run. HOT 1
- Expand enqueue options media player HOT 2
- Extend Rest API - unique_id HOT 3
- Add "status" as an attribute to CalendarEvents HOT 5
- Add list of (upcoming) calendar events to templating HOT 1
- Creating automations on the fly HOT 1
- Optional health check HOT 2
- Open letter for improving Home Assistant's Authentication system HOT 7
- Add device_class Heater HOT 2
- Area Units HOT 3
- New Device class for Reactive Energy (varh) HOT 1
- "Lost" device HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from architecture.