Comments (5)
So I just added a PR that introduces hass.async_add_executor_job
. This function could probably replace like 80% of all calls to async_add_job. One thing that I like about this is that it will make it clear where we are using the executor.
from architecture.
We can't add a parameter to the function to make it choose something.. what you're proposing is a new function.
We were talking about that the other day with @andrey-git. I'm on my phone so don't know the pr anymore but we had list to split it up
from architecture.
Found the comment. home-assistant/core#14429 (comment)
As initial plans were already laid out in that comment, I don't mind if we add a new function async_add_executor_job
that behaves similar to async_add_job
for threaded functions.
from architecture.
My problem with split the code is, that's never possible to cleanup the old code. At the end we mess the code base with a new function for maybe 400ms per 1milion requests.
I think we shold focus for a clean code base (core) they work as simple as possible. For Typing. We use python and that give this project the magic while we can do stuff that are not possible in other language. For runtime, typing make no change in python and that mean it's not usable.
from architecture.
Yeah I'm fine with this function but I say only that it's never been possible to cleanup the code base and we need maintain this two function with same functionality until the end of home-assistant asyncio usage :)
from architecture.
Related Issues (20)
- Splitting tests files in smaller files in components/modules tests HOT 1
- Feature Request HOT 1
- Add favorite position to Cover entity HOT 10
- Add feature light distribution control to LightEntity
- Add new CURRENT_HVAC constants HOT 1
- Add Home Appliance entity
- Officially allow enities to set their entity ID not based on their names HOT 2
- Custom Device Class for Binary Sensors HOT 9
- Installed homeassistant supervised on my Linux machine; can't get it to run. HOT 1
- Expand enqueue options media player HOT 2
- Extend Rest API - unique_id HOT 3
- Add "status" as an attribute to CalendarEvents HOT 5
- Add list of (upcoming) calendar events to templating HOT 1
- Creating automations on the fly HOT 1
- Optional health check HOT 2
- Open letter for improving Home Assistant's Authentication system HOT 7
- Add device_class Heater HOT 2
- Area Units HOT 3
- New Device class for Reactive Energy (varh) HOT 1
- "Lost" device HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from architecture.