Comments (11)
I also like the idea, actually some components such as camera already have brand and model properties:
from architecture.
I like this idea a lot . We won't pollute the state machine with it. I think the entity registry is an excellent place to change this as it won't ever change (contrary to say, firmware version).
from architecture.
Thanks for the feedback! I'll stay tuned for any other comments, and probably prepare a PR near the end of the week
from architecture.
I like it too. Having additional details at hand can help to debug issues. I'm thinking about the TP-Link switch support that broke with new firmware or the no-name/relabeled devices from Asia which belong to family of identical devices which are just sold under different names.
from architecture.
We should make sure to align those. Note that this property will only be used for entities with a unique id.
from architecture.
As pointed out by @dgomes , the current Camera Entity class uses brand
and model
, whereas my proposal is manufacturer_name
and model_name
.
Any strong opinions on naming? I slightly prefer manufacturer_name
over brand
, but I don't feel strongly about it
from architecture.
I prefer it as Zigbee does it; uses modelid and manufacturer
from architecture.
The downside of model id is that we can't just show it in the frontend.
from architecture.
@balloob I see them as the same thing
from architecture.
Interesting. I would expect id
to reference an identifier, name
to reference a name.
I think that we should have the names contain the source + the attribute. So I wouldn't like manufacturer
, I would prefer manufacturer_name
. I think for model, initially I would be interested in the model_name
, not the model_id
. I would want to show a list of devices in Home Assistant.
from architecture.
@balloob we can close this I think. It was solved with the device registry.
See #36.
from architecture.
Related Issues (20)
- Splitting tests files in smaller files in components/modules tests HOT 1
- Feature Request HOT 1
- Add favorite position to Cover entity HOT 10
- Add feature light distribution control to LightEntity
- Add new CURRENT_HVAC constants HOT 1
- Add Home Appliance entity
- Officially allow enities to set their entity ID not based on their names HOT 2
- Custom Device Class for Binary Sensors HOT 9
- Installed homeassistant supervised on my Linux machine; can't get it to run. HOT 1
- Expand enqueue options media player HOT 2
- Extend Rest API - unique_id HOT 3
- Add "status" as an attribute to CalendarEvents HOT 5
- Add list of (upcoming) calendar events to templating HOT 1
- Creating automations on the fly HOT 1
- Optional health check HOT 2
- Open letter for improving Home Assistant's Authentication system HOT 7
- Add device_class Heater HOT 2
- Area Units HOT 3
- New Device class for Reactive Energy (varh) HOT 1
- "Lost" device HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from architecture.