RFC: Battery Charging attribute about architecture

[schmittx]

You nailed it, I think a list of official attributes would be very helpful and ensure consistency.

My image for charging status specifically would be an addition to homeassistant/const.py as you mentioned. I'm just not sure if a boolean value is robust enough or if it should be more granular (i.e. charging, not_charging, full, not_supported, unplugged, etc.).

[balloob]

So this brings up another interesting issue, as for one, we don't have a list of official attributes. Note that the list here are properties. Things that one can define on an entity and that will be stored in the state attributes.

So if this is a proposal for a property, I would say no, there is not a common enough use case.

However, if this is just a proposal for an attribute which we define in homeassistant/const.py, I would say: why not. However, in that case we would also introduce a new page in our dev docs to talk about such attributes and what value it should hold.

[schmittx]

Is there anyone that can help with updating the dev docs to create a section describing attributes? I'm not so good with HTML stuff, but can help with content once a structure/format is established...

[balloob]

You don't need any HTML knowledge, it's all markdown (same syntax as the comments you're typing here).

Entity page is here: https://developers.home-assistant.io/docs/en/entity_index.html

[schmittx]

Gotcha, I don't know what I was looking at initially...lots of late nights lately...

I created an initial PR, any feedback is much appreciated.

[schmittx]

PR for battery charging has been created, thanks for the feedback and help so far!