Coder Social home page Coder Social logo

Comments (8)

philippjfr avatar philippjfr commented on May 14, 2024

I'd probably try going back to the commit before that PR and then try to figure out the structure of the generated bokeh models. My initial guess is that something about the WidgetBox each Div is in has changed.

from panel.

jbednar avatar jbednar commented on May 14, 2024

Unless I'm confused, I don't think the spacing change has anything to do with that PR itself, because the example above was done with the code in the PR. I.e., it seems like something outside of the Panel code is what's changed, as that same Panel code used to behave differently than it does now.

from panel.

philippjfr avatar philippjfr commented on May 14, 2024

Unless I'm confused, I don't think the spacing change has anything to do with that PR itself, because the example above was done with the code in the PR.

The PR was rebased towards the end before merging, so that image was probably generated before that was done, in which case you might have to go a few commits back from there.

from panel.

jbednar avatar jbednar commented on May 14, 2024

Ah, that would explain it. I'll see if I can narrow it down.

from panel.

jbednar avatar jbednar commented on May 14, 2024

Ok, I was able to narrow it down. It was tricky, because the API changed so many times, but here's some code that runs across versions:

from IPython.display import HTML as ipyHTML
h = ipyHTML("<u>HTML</u>")

import param, panel as pn, numpy as np
try:
    from panel.pane import Pane
    from panel.pane import HTML
except:
    try:
        from panel.panes import Pane
        from panel.panes import HTMLPane as HTML
    except:
        try:
            from panel.panes import Pane
            from panel.panes import HTML     
        except:
            from panel.panels import Panel as Pane
            from panel.panels import HTMLPanel as HTML

pn.extension()

pn.Row(HTML(h), HTML(h), HTML(h))

The output is what I'd expect, in commit 3cea6f2 (Sep 4, "Wrap raw bokeh model widgets in WidgetBox (#22)"):

image

And it all gets spaced out in the next commit f685db4 (Sep 5 , "Always wrap Div and widgets in WidgetBox (#25)")
image

from panel.

jbednar avatar jbednar commented on May 14, 2024

The notes for the PR say that it's about making sizing more consistent, but to me it looks like wrapping things in WidgetBoxes is messing things up...

from panel.

philippjfr avatar philippjfr commented on May 14, 2024

Having trouble seeing how either of those commits could be the cause since they apply only to the Bokeh pane, but I'll keep looking.

from panel.

philippjfr avatar philippjfr commented on May 14, 2024

Nevermind I see the issue.

from panel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.